Skip to content

Commit 8189b9a

Browse files
committed
Merge branch 'bugfix/remove_i2s_bbpll_clk_enable_v3.3' into 'release/v3.3'
bugfix(i2s): remove_i2s_bbpll_clk_enable(backport v3.3) See merge request sdk/ESP8266_RTOS_SDK!1425
2 parents 52419ec + 85759ce commit 8189b9a

File tree

2 files changed

+2
-29
lines changed

2 files changed

+2
-29
lines changed

components/esp8266/driver/i2s.c

-27
Original file line numberDiff line numberDiff line change
@@ -48,30 +48,6 @@ static const char *I2S_TAG = "i2s";
4848
#define dma_intr_disable() _xt_isr_mask(1 << ETS_SLC_INUM)
4949
#define dma_intr_register(a, b) _xt_isr_attach(ETS_SLC_INUM, (a), (b))
5050

51-
// Define them here if we can't find them.
52-
#ifndef i2c_bbpll
53-
#define i2c_bbpll 0x67
54-
#define i2c_bbpll_en_audio_clock_out 4
55-
#define i2c_bbpll_en_audio_clock_out_msb 7
56-
#define i2c_bbpll_en_audio_clock_out_lsb 7
57-
#define i2c_bbpll_hostid 4
58-
59-
/* ROM functions which read/write internal control bus */
60-
uint8_t rom_i2c_readReg(uint8_t block, uint8_t host_id, uint8_t reg_add);
61-
uint8_t rom_i2c_readReg_Mask(uint8_t block, uint8_t host_id, uint8_t reg_add, uint8_t msb, uint8_t lsb);
62-
void rom_i2c_writeReg(uint8_t block, uint8_t host_id, uint8_t reg_add, uint8_t data);
63-
void rom_i2c_writeReg_Mask(uint8_t block, uint8_t host_id, uint8_t reg_add, uint8_t msb, uint8_t lsb, uint8_t data);
64-
65-
#define i2c_writeReg_Mask(block, host_id, reg_add, Msb, Lsb, indata) rom_i2c_writeReg_Mask(block, host_id, reg_add, Msb, Lsb, indata)
66-
#define i2c_readReg_Mask(block, host_id, reg_add, Msb, Lsb) rom_i2c_readReg_Mask(block, host_id, reg_add, Msb, Lsb)
67-
#define i2c_writeReg_Mask_def(block, reg_add, indata) \
68-
i2c_writeReg_Mask(block, block##_hostid, reg_add, reg_add##_msb, reg_add##_lsb, indata)
69-
#define i2c_readReg_Mask_def(block, reg_add) \
70-
i2c_readReg_Mask(block, block##_hostid, reg_add, reg_add##_msb, reg_add##_lsb)
71-
#endif
72-
#define I2S_CLK_ENABLE() i2c_writeReg_Mask_def(i2c_bbpll, i2c_bbpll_en_audio_clock_out, 1)
73-
#define I2S_CLK_DISABLE() i2c_writeReg_Mask_def(i2c_bbpll, i2c_bbpll_en_audio_clock_out, 0)
74-
7551
#define I2S_MAX_BUFFER_SIZE (4 * 1024 * 1024) // the maximum RAM can be allocated
7652
#define I2S_BASE_CLK (2 * APB_CLK_FREQ)
7753
#define I2S_ENTER_CRITICAL() portENTER_CRITICAL()
@@ -864,8 +840,6 @@ esp_err_t i2s_driver_uninstall(i2s_port_t i2s_num)
864840
heap_caps_free(p_i2s_obj[i2s_num]);
865841
p_i2s_obj[i2s_num] = NULL;
866842

867-
I2S_CLK_DISABLE();
868-
869843
return ESP_OK;
870844
}
871845

@@ -894,7 +868,6 @@ esp_err_t i2s_driver_install(i2s_port_t i2s_num, const i2s_config_t *i2s_config,
894868

895869
//initial interrupt
896870
dma_intr_register(i2s_intr_handler_default, p_i2s_obj[i2s_num]);
897-
I2S_CLK_ENABLE();
898871
i2s_stop(i2s_num);
899872
err = i2s_param_config(i2s_num, i2s_config);
900873

components/esp8266/include/esp8266/i2s_register.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
#ifndef _SLC_REGISTER_H_
16-
#define _SLC_REGISTER_H_
15+
#ifndef _I2S_REGISTER_H_
16+
#define _I2S_REGISTER_H_
1717

1818
#include "eagle_soc.h"
1919

0 commit comments

Comments
 (0)