From 9b35867a377afbdac03627c6160cc67258d311e6 Mon Sep 17 00:00:00 2001 From: Ringo Stahl Date: Wed, 27 Nov 2019 12:14:38 +0100 Subject: [PATCH] removed double delete of characteristics --- libraries/BLE/src/BLERemoteService.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libraries/BLE/src/BLERemoteService.cpp b/libraries/BLE/src/BLERemoteService.cpp index 278e9c1cab4..3b5b52d79f1 100644 --- a/libraries/BLE/src/BLERemoteService.cpp +++ b/libraries/BLE/src/BLERemoteService.cpp @@ -302,13 +302,10 @@ std::string BLERemoteService::getValue(BLEUUID characteristicUuid) { * @return N/A. */ void BLERemoteService::removeCharacteristics() { - for (auto &myPair : m_characteristicMap) { - delete myPair.second; - //m_characteristicMap.erase(myPair.first); // Should be no need to delete as it will be deleted by the clear - } m_characteristicMap.clear(); // Clear the map for (auto &myPair : m_characteristicMapByHandle) { delete myPair.second; + // delete the characteristics only once } m_characteristicMapByHandle.clear(); // Clear the map } // removeCharacteristics