Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have different behaviors on bundle.properties and messages.properties files (enhancement) #66

Open
sebjacquot opened this issue Apr 11, 2017 · 0 comments

Comments

@sebjacquot
Copy link

Hi,
very great tool I've discovered a few time ago, thank you very much to bring it to us.
I would have some proposals that may be useful for us and hopefully for others. I use the tool on OSGI/bundle.properties but also messages.properties. The two systems have some differences :

bundle.properties

  • use pattern as command.name, page.name
  • does not support UTF-8
  • RBE options : "separator = . " and "convert unicode values to \uXXXX = true"

messages.properties and class Messages.java

  • can not use the point character, because the keys are also the member names defined in Messages.java (unfortunately Java only permits the underscore character that can be used as separator in this case)
  • support UTF-8 (with some tricks)
  • RBE options : "separator = _" and "convert unicode values to \uXXXX = false"

So with the current version of RBE we can not use it for both case without changing preferences each time we want to edit bundle or messages.

For the separator, maybe the more simple should be to permit a list of separator strings?

There is also a little problem, because the underscore character is generally also used as a "space" in key name I think a good improvement would be to have a preference to define the group depth, eg. 1 stops the group splitting to the first found underscore. In this way RBE could manage a tree as :

ERROR_CANT_WRITE_TO_FILE
ERROR_MISSING_PARAMETER

by creating only the group and node "ERROR" instead of ERROR=>CANT=>WRITE=> etc.

Thanks for reading.
Sebastian

(an F2 shortcut to rename a key will also be very nice ! :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant