Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the RPC usage mandatory if needed. #446

Closed
Tracked by #396
Ethnical opened this issue Jan 7, 2025 · 1 comment
Closed
Tracked by #396

Make the RPC usage mandatory if needed. #446

Ethnical opened this issue Jan 7, 2025 · 1 comment

Comments

@Ethnical
Copy link
Contributor

Ethnical commented Jan 7, 2025

In the task https://github.com/ethereum-optimism/superchain-ops/blob/main/tasks/eth/ink-001-permissionless-proofs/VALIDATION.md#0xde744491bcf6[…]teregistryproxy

We should make sure, that if the RPC usage is needed into the Validation file that there is an EXPLICIT way to get access and all the command needed to do it as mandatory and not OPTIONAL.

Feedback from a signer:

"If you have access to ink rpc url" is going to confuse people. It needs to be obvious what to do. It should be either "get an ink rpc url, this is how you get one and do this check" or it should be deleted

@blmalone blmalone changed the title Make the RPC usage mandatory is needed. Make the RPC usage mandatory if needed. Jan 14, 2025
@blmalone
Copy link
Contributor

Thanks for raising this. Given that this task is more like a guideline and not something that can be actioned and completed permanently, I'm going to close this. I think you should raise this is you're reviewing PRs that aren't following this guideline. Let me know if you'd like to reopen, or I've misunderstood this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants