Skip to content

Commit 4be68af

Browse files
committed
Put python3.8 support back in:
- We should create a breaking changes branch to be merged only when we are ready to start the next major version release cycle for all our maintained libraries.
1 parent c6a24e4 commit 4be68af

File tree

4 files changed

+30
-7
lines changed

4 files changed

+30
-7
lines changed

.circleci/config.yml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,12 @@ jobs:
123123
environment:
124124
TOXENV: docs
125125

126+
py38-core:
127+
<<: *common
128+
docker:
129+
- image: cimg/python:3.8
130+
environment:
131+
TOXENV: py38-core
126132
py39-core:
127133
<<: *common
128134
docker:
@@ -154,6 +160,12 @@ jobs:
154160
environment:
155161
TOXENV: py313-core
156162

163+
py38-lint:
164+
<<: *common
165+
docker:
166+
- image: cimg/python:3.8
167+
environment:
168+
TOXENV: py38-lint
157169
py39-lint:
158170
<<: *common
159171
docker:
@@ -185,6 +197,12 @@ jobs:
185197
environment:
186198
TOXENV: py313-lint
187199

200+
py38-wheel:
201+
<<: *common
202+
docker:
203+
- image: cimg/python:3.8
204+
environment:
205+
TOXENV: py38-wheel
188206
py39-wheel:
189207
<<: *common
190208
docker:
@@ -257,16 +275,19 @@ jobs:
257275

258276
define: &all_jobs
259277
- docs
278+
- py38-core
260279
- py39-core
261280
- py310-core
262281
- py311-core
263282
- py312-core
264283
- py313-core
284+
- py38-lint
265285
- py39-lint
266286
- py310-lint
267287
- py311-lint
268288
- py312-lint
269289
- py313-lint
290+
- py38-wheel
270291
- py39-wheel
271292
- py310-wheel
272293
- py311-wheel

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ repos:
1111
rev: v3.15.0
1212
hooks:
1313
- id: pyupgrade
14-
args: [--py39-plus]
14+
args: [--py38-plus]
1515
- repo: https://github.com/psf/black
1616
rev: 23.9.1
1717
hooks:

setup.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
install_requires=[
5151
"eth-utils>=2",
5252
],
53-
python_requires=">=3.9, <4",
53+
python_requires=">=3.8, <4",
5454
extras_require=extras_require,
5555
py_modules=["<MODULE_NAME>"],
5656
license="MIT",
@@ -64,6 +64,7 @@
6464
"License :: OSI Approved :: MIT License",
6565
"Natural Language :: English",
6666
"Programming Language :: Python :: 3",
67+
"Programming Language :: Python :: 3.8",
6768
"Programming Language :: Python :: 3.9",
6869
"Programming Language :: Python :: 3.10",
6970
"Programming Language :: Python :: 3.11",

tox.ini

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
[tox]
22
envlist=
3-
py{39,310,311,312,313}-core
4-
py{39,310,311,312,313}-lint
5-
py{39,310,311,312,313}-wheel
3+
py{38,39,310,311,312,313}-core
4+
py{38,39,310,311,312,313}-lint
5+
py{38,39,310,311,312,313}-wheel
66
windows-wheel
77
docs
88

@@ -23,6 +23,7 @@ commands=
2323
basepython=
2424
docs: python
2525
windows-wheel: python
26+
py38: python3.8
2627
py39: python3.9
2728
py310: python3.10
2829
py311: python3.11
@@ -33,13 +34,13 @@ extras=
3334
docs
3435
allowlist_externals=make,pre-commit
3536

36-
[testenv:py{39,310,311,312,313}-lint]
37+
[testenv:py{38,39,310,311,312,313}-lint]
3738
deps=pre-commit
3839
commands=
3940
pre-commit install
4041
pre-commit run --all-files --show-diff-on-failure
4142

42-
[testenv:py{39,310,311,312,313}-wheel]
43+
[testenv:py{38,39,310,311,312,313}-wheel]
4344
deps=
4445
wheel
4546
build[virtualenv]

0 commit comments

Comments
 (0)