Skip to content

Commit 1f91e55

Browse files
committed
Ensure tests aren't accidentially run against wrong fork
Some test directories have fork names in the directory name. Globbing tests based on -k <ForkName> causes tests against <ForkName> to include tests that actuall go against <OtherForkName> only because <ForkName> matches against the glob because it appears in the directory name.
1 parent e806ef8 commit 1f91e55

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

tox.ini

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -25,25 +25,25 @@ commands=
2525
p2p: pytest {posargs:tests/p2p}
2626
database: pytest {posargs:tests/database}
2727
rpc-blockchain: pytest {posargs:tests/trinity/json-fixtures-over-rpc/test_rpc_fixtures.py -k 'not GeneralStateTests'}
28-
rpc-state-frontier: pytest {posargs:tests/trinity/json-fixtures-over-rpc/test_rpc_fixtures.py -k 'GeneralStateTests and not stQuadraticComplexityTest and Frontier'}
29-
rpc-state-homestead: pytest {posargs:tests/trinity/json-fixtures-over-rpc/test_rpc_fixtures.py -k 'GeneralStateTests and not stQuadraticComplexityTest and Homestead'}
30-
rpc-state-eip150: pytest {posargs:tests/trinity/json-fixtures-over-rpc/test_rpc_fixtures.py -k 'GeneralStateTests and not stQuadraticComplexityTest and EIP150'}
31-
rpc-state-eip158: pytest {posargs:tests/trinity/json-fixtures-over-rpc/test_rpc_fixtures.py -k 'GeneralStateTests and not stQuadraticComplexityTest and EIP158'}
28+
rpc-state-frontier: pytest {posargs:tests/trinity/json-fixtures-over-rpc/test_rpc_fixtures.py -k 'GeneralStateTests and not stQuadraticComplexityTest and ":Frontier"'}
29+
rpc-state-homestead: pytest {posargs:tests/trinity/json-fixtures-over-rpc/test_rpc_fixtures.py -k 'GeneralStateTests and not stQuadraticComplexityTest and ":Homestead"'}
30+
rpc-state-eip150: pytest {posargs:tests/trinity/json-fixtures-over-rpc/test_rpc_fixtures.py -k 'GeneralStateTests and not stQuadraticComplexityTest and ":EIP150"'}
31+
rpc-state-eip158: pytest {posargs:tests/trinity/json-fixtures-over-rpc/test_rpc_fixtures.py -k 'GeneralStateTests and not stQuadraticComplexityTest and ":EIP158"'}
3232
beacon: pytest {posargs:tests/beacon/}
3333
# The following test seems to consume a lot of memory. Restricting to 3 processes reduces crashes
34-
rpc-state-byzantium: pytest -n3 {posargs:tests/trinity/json-fixtures-over-rpc/test_rpc_fixtures.py -k 'GeneralStateTests and not stQuadraticComplexityTest and Byzantium'}
35-
rpc-state-constantinople: pytest -n3 {posargs:tests/trinity/json-fixtures-over-rpc/test_rpc_fixtures.py -k 'GeneralStateTests and not stQuadraticComplexityTest and Constantinople'}
34+
rpc-state-byzantium: pytest -n3 {posargs:tests/trinity/json-fixtures-over-rpc/test_rpc_fixtures.py -k 'GeneralStateTests and not stQuadraticComplexityTest and ":Byzantium"'}
35+
rpc-state-constantinople: pytest -n3 {posargs:tests/trinity/json-fixtures-over-rpc/test_rpc_fixtures.py -k 'GeneralStateTests and not stQuadraticComplexityTest and ":Constantinople"'}
3636
rpc-state-quadratic: pytest {posargs:tests/trinity/json-fixtures-over-rpc/test_rpc_fixtures.py -k 'GeneralStateTests and stQuadraticComplexityTest'}
3737
transactions: pytest {posargs:tests/json-fixtures/test_transactions.py}
3838
vm: pytest {posargs:tests/json-fixtures/test_virtual_machine.py}
3939
native-blockchain: pytest {posargs:tests/json-fixtures/test_blockchain.py}
40-
native-state-frontier: pytest {posargs:tests/json-fixtures/test_state.py -k Frontier}
41-
native-state-homestead: pytest {posargs:tests/json-fixtures/test_state.py -k Homestead}
42-
native-state-eip150: pytest {posargs:tests/json-fixtures/test_state.py -k EIP150}
43-
native-state-eip158: pytest {posargs:tests/json-fixtures/test_state.py -k EIP158}
44-
native-state-byzantium: pytest {posargs:tests/json-fixtures/test_state.py -k Byzantium}
45-
native-state-constantinople: pytest {posargs:tests/json-fixtures/test_state.py -k Constantinople}
46-
native-state-metropolis: pytest {posargs:tests/json-fixtures/test_state.py -k Metropolis}
40+
native-state-frontier: pytest {posargs:tests/json-fixtures/test_state.py -k :Frontier}
41+
native-state-homestead: pytest {posargs:tests/json-fixtures/test_state.py -k :Homestead}
42+
native-state-eip150: pytest {posargs:tests/json-fixtures/test_state.py -k :EIP150}
43+
native-state-eip158: pytest {posargs:tests/json-fixtures/test_state.py -k :EIP158}
44+
native-state-byzantium: pytest {posargs:tests/json-fixtures/test_state.py -k :Byzantium}
45+
native-state-constantinople: pytest {posargs:tests/json-fixtures/test_state.py -k :Constantinople}
46+
native-state-metropolis: pytest {posargs:tests/json-fixtures/test_state.py -k :Metropolis}
4747
lightchain_integration: pytest --integration {posargs:tests/trinity/integration/test_lightchain_integration.py}
4848

4949
deps = .[p2p,trinity,eth-extra,test]

0 commit comments

Comments
 (0)