Check for empty header payload

ethereumjs · Feb 28, 2025 · 3a41ec8 · 3a41ec8
1 parent 4cefc9f
commit 3a41ec8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/packages/portalnetwork/src/networks/history/history.ts b/packages/portalnetwork/src/networks/history/history.ts
@@ -566,6 +566,10 @@ export class HistoryNetwork extends BaseNetwork {
 
       case HistoryNetworkContentType.EphemeralHeader: {
         const payload = EphemeralHeaderPayload.deserialize(value)
+        if (payload.length === 0) {
+          this.logger.extend('STORE')('Received empty ephemeral header payload')
+          return
+        }
         try {
           // Verify first header matches requested header
           const firstHeader = BlockHeader.fromRLPSerializedHeader(payload[0], { setHardfork: true })

diff --git a/packages/portalnetwork/test/integration/ephemeralHeaders.spec.ts b/packages/portalnetwork/test/integration/ephemeralHeaders.spec.ts
@@ -87,6 +87,7 @@ describe('should be able to retrieve ephemeral headers from a peer', () => {
       assert.fail('Expected content in response')
     }
 
+    // Verify that we get a single ancestor for a content key with an ancestor count of 1
     const contentKeyForOneAncestor = getContentKey(HistoryNetworkContentType.EphemeralHeader, {
       blockHash: headers[0].hash(),
       ancestorCount: 1,
@@ -116,5 +117,5 @@ describe('should be able to retrieve ephemeral headers from a peer', () => {
     } else {
       assert.fail('Expected content in response')
     }
-  }, 10000)
+  })
 })