metrics: add metric for talkReq and talkResp sent

ethereumjs · Nov 2, 2024 · 5a4f3a5 · 5a4f3a5
1 parent 5d714e9
commit 5a4f3a5
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/packages/portalnetwork/src/networks/network.ts b/packages/portalnetwork/src/networks/network.ts
@@ -115,10 +115,18 @@ export abstract class BaseNetwork extends EventEmitter {
     networkId: NetworkId,
     utpMessage?: boolean,
   ): Promise<Uint8Array> {
+    if (this.portal.metrics) {
+      const metric = (this.networkName + '_talkRequestsSent') as keyof PortalNetworkMetrics
+      this.portal.metrics[metric].inc()
+    }
     return this.portal.sendPortalNetworkMessage(enr, payload, networkId, utpMessage)
   }
 
   sendResponse(src: INodeAddress, requestId: bigint, payload: Uint8Array): Promise<void> {
+    if (this.portal.metrics) {
+      const metric = (this.networkName + '_talkResponsesSent') as keyof PortalNetworkMetrics
+      this.portal.metrics[metric].inc()
+    }
     return this.portal.sendPortalNetworkResponse(src, requestId, payload)
   }
   findEnr(nodeId: string): ENR | undefined {

diff --git a/packages/portalnetwork/src/util/metrics.ts b/packages/portalnetwork/src/util/metrics.ts
@@ -50,15 +50,25 @@ const createMetrics = (metrics: MetricParams[], networks: NetworkId[]) => {
 
 const ultralightMetrics = [
   {
-    metric: MetricType.Gauge,
     name: 'peers',
+    metric: MetricType.Gauge,
     help: 'how many peers are in the routing table',
   },
   {
-    metric: MetricType.Gauge,
     name: 'dbSize',
+    metric: MetricType.Gauge,
     help: 'how many MBs are currently stored in the db',
   },
+  {
+    name: 'talkRequestsSent',
+    metric: MetricType.Counter,
+    help: 'how many talk requests have been sent',
+  },
+  {
+    name: 'talkResponsesReceived',
+    metric: MetricType.Counter,
+    help: 'how many talk responses have been sent',
+  },
 ]
 
 export const setupMetrics = (