Use non-capturing regex for data to prevent memory exhaustion for long strings (#4741).

ricmoo · ricmoo · commit 5463aa03eacd · 2024-05-29T13:48:38.000-04:00
diff --git a/src.ts/utils/data.ts b/src.ts/utils/data.ts
@@ -31,7 +31,7 @@ function _getBytes(value: BytesLike, name?: string, copy?: boolean): Uint8Array
         return value;
     }
 
-    if (typeof(value) === "string" && value.match(/^0x([0-9a-f][0-9a-f])*$/i)) {
+    if (typeof(value) === "string" && value.match(/^0x(?:[0-9a-f][0-9a-f])*$/i)) {
         const result = new Uint8Array((value.length - 2) / 2);
         let offset = 2;
         for (let i = 0; i < result.length; i++) {

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ function _getBytes(value: BytesLike, name?: string, copy?: boolean): Uint8Array`
`31`	`31`	`return value;`
`32`	`32`	`}`
`33`	`33`
`34`		`- if (typeof(value) === "string" && value.match(/^0x([0-9a-f][0-9a-f])*$/i)) {`
	`34`	`+ if (typeof(value) === "string" && value.match(/^0x(?:[0-9a-f][0-9a-f])*$/i)) {`
`35`	`35`	`const result = new Uint8Array((value.length - 2) / 2);`
`36`	`36`	`let offset = 2;`
`37`	`37`	`for (let i = 0; i < result.length; i++) {`