Skip to content

Introduce "upgrade protocol" (websockets) #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
etr opened this issue Jan 19, 2019 · 3 comments
Open

Introduce "upgrade protocol" (websockets) #135

etr opened this issue Jan 19, 2019 · 3 comments
Labels
feature-request Feature requests or enhancements

Comments

@etr
Copy link
Owner

etr commented Jan 19, 2019

Is your feature request related to a problem? Please describe.
"upgrade protocol" is now supported by libmicrohttpd. We should reach feature parity to allow users to use it (without having to go back to the wrapped library)

Describe why the feature or enhancement you are proposing fits the library.
Reach feature parity on upgrade protocol. This will likely need to be implemented as a new response_type.

Describe the solution you'd like
This will likely need to be implemented as a new response_type.

@etr etr added the feature-request Feature requests or enhancements label Jan 19, 2019
@neilyoung
Copy link

I suppose, there is still no support for websockets?

@LeSpocky
Copy link
Contributor

I suppose, there is still no support for websockets?

libmicrohttpd gained experimental websockets support in December 2021 with version 0.9.74, see their announcment: https://lists.gnu.org/archive/html/libmicrohttpd/2021-12/msg00052.html

@etr
Copy link
Owner Author

etr commented Jan 19, 2022

There is a proposed PR that would add support to websockets here: #236

The only thing blocking it is that it moves the dependency to the experimental version forcefully rather than optionally. I believe this could be fixed easily. I might not have the time right now to fix it, but I'd welcome changes to that PR addressing the issue. That would close a gap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Feature requests or enhancements
Projects
None yet
Development

No branches or pull requests

3 participants