From 678eeae55a21cde1255270f682fb3522622e25bf Mon Sep 17 00:00:00 2001
From: Babis Routis <127745316+babisRoutis@users.noreply.github.com>
Date: Tue, 19 Nov 2024 11:40:41 +0200
Subject: [PATCH] Removed credential_identifiers_supported from issuer metadata
 (#343)

---
 .../ec/eudi/openid4vci/CredentialIssuerMetadataResolver.kt      | 1 -
 .../internal/http/CredentialIssuerMetadataJsonParser.kt         | 2 --
 src/test/kotlin/eu/europa/ec/eudi/openid4vci/MockData.kt        | 1 -
 3 files changed, 4 deletions(-)

diff --git a/src/main/kotlin/eu/europa/ec/eudi/openid4vci/CredentialIssuerMetadataResolver.kt b/src/main/kotlin/eu/europa/ec/eudi/openid4vci/CredentialIssuerMetadataResolver.kt
index 0b252585..2caa064f 100644
--- a/src/main/kotlin/eu/europa/ec/eudi/openid4vci/CredentialIssuerMetadataResolver.kt
+++ b/src/main/kotlin/eu/europa/ec/eudi/openid4vci/CredentialIssuerMetadataResolver.kt
@@ -77,7 +77,6 @@ data class CredentialIssuerMetadata(
     val notificationEndpoint: CredentialIssuerEndpoint? = null,
     val credentialResponseEncryption: CredentialResponseEncryption = CredentialResponseEncryption.NotSupported,
     val batchCredentialIssuance: BatchCredentialIssuance = BatchCredentialIssuance.NotSupported,
-    val credentialIdentifiersSupported: Boolean = false,
     val credentialConfigurationsSupported: Map<CredentialConfigurationIdentifier, CredentialConfiguration>,
     val display: List<Display> = emptyList(),
 ) : Serializable {
diff --git a/src/main/kotlin/eu/europa/ec/eudi/openid4vci/internal/http/CredentialIssuerMetadataJsonParser.kt b/src/main/kotlin/eu/europa/ec/eudi/openid4vci/internal/http/CredentialIssuerMetadataJsonParser.kt
index db15145a..56293da0 100644
--- a/src/main/kotlin/eu/europa/ec/eudi/openid4vci/internal/http/CredentialIssuerMetadataJsonParser.kt
+++ b/src/main/kotlin/eu/europa/ec/eudi/openid4vci/internal/http/CredentialIssuerMetadataJsonParser.kt
@@ -379,7 +379,6 @@ private data class CredentialIssuerMetadataTO(
     @SerialName("notification_endpoint") val notificationEndpoint: String? = null,
     @SerialName("credential_response_encryption") val credentialResponseEncryption: CredentialResponseEncryptionTO? = null,
     @SerialName("batch_credential_issuance") val batchCredentialIssuance: BatchCredentialIssuanceTO? = null,
-    @SerialName("credential_identifiers_supported") val credentialIdentifiersSupported: Boolean = false,
     @SerialName("signed_metadata") val signedMetadata: String? = null,
     @SerialName("credential_configurations_supported") val credentialConfigurationsSupported: Map<String, CredentialSupportedTO> =
         emptyMap(),
@@ -435,7 +434,6 @@ private data class CredentialIssuerMetadataTO(
             notificationEndpoint,
             credentialResponseEncryption(),
             batchIssuance,
-            credentialIdentifiersSupported,
             credentialsSupported,
             display,
         )
diff --git a/src/test/kotlin/eu/europa/ec/eudi/openid4vci/MockData.kt b/src/test/kotlin/eu/europa/ec/eudi/openid4vci/MockData.kt
index 18d24c25..7e860bca 100644
--- a/src/test/kotlin/eu/europa/ec/eudi/openid4vci/MockData.kt
+++ b/src/test/kotlin/eu/europa/ec/eudi/openid4vci/MockData.kt
@@ -318,7 +318,6 @@ internal fun credentialIssuerMetadata() = CredentialIssuerMetadata(
         ),
     ),
     BatchCredentialIssuance.Supported(batchSize = 2),
-    true,
     mapOf(
         CredentialConfigurationIdentifier("UniversityDegree_JWT") to universityDegreeJwt(),
         CredentialConfigurationIdentifier("MobileDrivingLicense_msoMdoc") to mobileDrivingLicense(),