From 0fe116ac316c6a4541c394b9cc7b8c624fdc4cb2 Mon Sep 17 00:00:00 2001 From: achtsnits Date: Thu, 7 Sep 2023 08:59:52 +0200 Subject: [PATCH] fix jupyter docker build --- .github/workflows/build-and-push-jupyter.yml | 3 ++- Dockerfile-jupyter | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-and-push-jupyter.yml b/.github/workflows/build-and-push-jupyter.yml index 9155e7c..a4cda4e 100644 --- a/.github/workflows/build-and-push-jupyter.yml +++ b/.github/workflows/build-and-push-jupyter.yml @@ -46,4 +46,5 @@ jobs: ${{ steps.login-ecr.outputs.registry }}/eurodatacube-jupyter:${{ steps.get_image_tag.outputs.TAG }} eurodatacube/jupyter:${{ steps.get_image_tag.outputs.TAG }} build-args: | - DOCKER_TAG=${{ steps.get_image_tag.outputs.TAG }} \ No newline at end of file + DOCKER_TAG=${{ steps.get_image_tag.outputs.TAG }} + BASE_IMAGE_TAG=${{ steps.get_image_tag.outputs.TAG }} \ No newline at end of file diff --git a/Dockerfile-jupyter b/Dockerfile-jupyter index 2821b61..da37105 100644 --- a/Dockerfile-jupyter +++ b/Dockerfile-jupyter @@ -1,6 +1,6 @@ ARG BASE_IMAGE_TAG -FROM 527538141574.dkr.ecr.eu-central-1.amazonaws.com/eoxhub-jupyterlab:2${BASE_IMAGE_TAG} +FROM 527538141574.dkr.ecr.eu-central-1.amazonaws.com/eoxhub-jupyterlab:${BASE_IMAGE_TAG} # NOTE: this is not a duplication, but a documented workaround # https://docs.docker.com/engine/reference/builder/#understand-how-arg-and-from-interact