Skip to content

Commit f8d9ed5

Browse files
authored
feat: removing story header; resetting theme when exploring data (#2743)
* feat: removing story header; resetting theme when exploring data * chore: updated upload artifact version * chore: adding unique names to artifacts
1 parent 10bde54 commit f8d9ed5

File tree

4 files changed

+17
-17
lines changed

4 files changed

+17
-17
lines changed

.github/workflows/feature-branch_deploy.yml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -114,15 +114,15 @@ jobs:
114114
working-directory: app
115115
spec: tests/e2e/specs/indicators_gtif.js
116116
config: 'baseUrl=https://${{ secrets.TEST_INSTANCE_UN }}:${{ secrets.TEST_INSTANCE_PW }}@gtif-testing.eox.at/${{ github.ref_name }}/'
117-
- uses: actions/upload-artifact@v3
117+
- uses: actions/upload-artifact@v4
118118
if: failure()
119119
with:
120-
name: cypress-screenshots
120+
name: cypress-screenshots-gtif
121121
path: app/tests/e2e/screenshots
122-
- uses: actions/upload-artifact@v3
122+
- uses: actions/upload-artifact@v4
123123
if: always()
124124
with:
125-
name: cypress-videos
125+
name: cypress-videos-gtif
126126
path: app/tests/e2e/videos
127127

128128
cypress-run-race:
@@ -141,16 +141,16 @@ jobs:
141141
spec: tests/e2e/specs/indicators_race.js
142142
config: 'baseUrl=https://${{ secrets.TEST_INSTANCE_UN }}:${{ secrets.TEST_INSTANCE_PW }}@eodash-testing.eox.at/${{ github.ref_name }}/'
143143

144-
- uses: actions/upload-artifact@v3
144+
- uses: actions/upload-artifact@v4
145145
if: failure()
146146
with:
147-
name: cypress-screenshots
147+
name: cypress-screenshots-race
148148
path: app/tests/e2e/screenshots
149149

150-
- uses: actions/upload-artifact@v3
150+
- uses: actions/upload-artifact@v4
151151
if: always()
152152
with:
153-
name: cypress-videos
153+
name: cypress-videos-race
154154
path: app/tests/e2e/videos
155155

156156
cypress-run-trilateral:
@@ -169,14 +169,14 @@ jobs:
169169
spec: tests/e2e/specs/indicators_trilateral.js
170170
config: 'baseUrl=https://${{ secrets.TEST_INSTANCE_UN }}:${{ secrets.TEST_INSTANCE_PW }}@eodash-trilateral-testing.eox.at/${{ github.ref_name }}/'
171171

172-
- uses: actions/upload-artifact@v3
172+
- uses: actions/upload-artifact@v4
173173
if: failure()
174174
with:
175-
name: cypress-screenshots
175+
name: cypress-screenshots-trilateral
176176
path: app/tests/e2e/screenshots
177177

178-
- uses: actions/upload-artifact@v3
178+
- uses: actions/upload-artifact@v4
179179
if: always()
180180
with:
181-
name: cypress-videos
181+
name: cypress-videos-trilateral
182182
path: app/tests/e2e/videos

app/src/components/GlobalHeader.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@
9696
text
9797
color="primary"
9898
block
99-
:to="{ name: 'explore' }"
99+
@click="loadTheme(null); $router.push({name: 'explore'})"
100100
>
101101
Explore Datasets
102102
</v-btn>
@@ -249,7 +249,7 @@
249249
text
250250
dark
251251
small
252-
:to="{ name: 'explore' }"
252+
@click="loadTheme(null); $router.push({name: 'explore'})"
253253
>
254254
Explore Datasets
255255
</v-btn>

app/src/components/ThemesLandingPage/StoriesGrid.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
class="ma-0 px-4 px-md-8"
44
style="max-width: 1400px;"
55
>
6-
<h3 class="mb-10" :class="[headingClass]">{{appConfig.branding.storiesHeader}}</h3>
6+
<!--<h3 class="mb-10" :class="[headingClass]">{{appConfig.branding.storiesHeader}}</h3>-->
77

88
<v-row
99
no-gutters

app/src/views/ThemeSinglePage.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,9 @@
7272
class="py-2 white--text"
7373
block
7474
max-height="44"
75-
:color="getCurrentTheme.color"
75+
color="primary"
7676
large
77-
@click="$router.push({name: 'explore'})"
77+
@click="loadTheme(null); $router.push({name: 'explore'})"
7878
>Explore Datasets</v-btn>
7979
</div>
8080
</v-col>

0 commit comments

Comments
 (0)