Skip to content

Commit 05aa7b6

Browse files
authored
Merge pull request nervosnetwork#4795 from eval-exec/exec/get-peers-dedup
`NetRpcImpl::get_peers` return `Remoteaddress.addresses` dedup
2 parents b44d2d2 + 9508269 commit 05aa7b6

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

rpc/src/module/net.rs

+4-2
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ use ckb_systemtime::unix_time_as_millis;
1111
use ckb_types::prelude::{Pack, Unpack};
1212
use jsonrpc_core::Result;
1313
use jsonrpc_utils::rpc;
14+
use std::collections::HashSet;
1415
use std::sync::Arc;
1516

1617
const MAX_ADDRS: usize = 50;
@@ -586,8 +587,9 @@ impl NetRpc for NetRpcImpl {
586587
.connected_peers()
587588
.iter()
588589
.map(|(peer_index, peer)| {
589-
let mut addresses = vec![&peer.connected_addr];
590-
addresses.extend(peer.listened_addrs.iter());
590+
let addresses: HashSet<_> = std::iter::once(peer.connected_addr.clone())
591+
.chain(peer.listened_addrs.iter().cloned())
592+
.collect();
591593

592594
let node_addresses = addresses
593595
.iter()

0 commit comments

Comments
 (0)