Merge pull request #47 from exceptionless/exception-with-message

Added method to submit exception with message

Author: pc9795

samples/example-app/src/main/java/com/exceptionless/example/app/ExampleApp.java

@@ -20,15 +20,12 @@ public static void sampleEventSubmissions() {
 
   public static void sampleUseOfSessions() {
     client.getConfigurationManager().useSessions();
-    client.submitEvent(
-        EventPluginContext.from(client.createSessionStart().userIdentity("test-user").build()));
+    client.submitEvent(client.createSessionStart().userIdentity("test-user").build());
     client.submitSessionEnd("test-user");
   }
 
   public static void sampleUseOfUpdatingEmailAndDescription() {
-    client.submitEvent(
-        EventPluginContext.from(
-            client.createLog("test-log").referenceId("test-reference-id").build()));
+    client.submitEvent(client.createLog("test-log").referenceId("test-reference-id").build());
     client.updateEmailAndDescription("test-reference-id", "[email protected]", "test-description");
   }
 

src/main/java/com/exceptionless/exceptionlessclient/ExceptionlessClient.java

@@ -92,12 +92,26 @@ public CompletableFuture<Void> submitExceptionAsync(Exception exception) {
   }
 
   public void submitException(Exception exception) {
-    Event event = createException().build();
+    submitException(null, exception);
+  }
+
+  public CompletableFuture<Void> submitExceptionAsync(String message, Exception exception) {
+    return CompletableFuture.runAsync(() -> submitException(message, exception), executorService);
+  }
+
+  public void submitException(String message, Exception exception) {
+    Event event;
+    if (message == null) {
+      event = createError().build();
+    } else {
+      event = createError().message(message).build();
+    }
     PluginContext pluginContext = PluginContext.builder().exception(exception).build();
-    submitEvent(EventPluginContext.builder().event(event).context(pluginContext).build());
+    submitEventWithContext(
+        EventPluginContext.builder().event(event).context(pluginContext).build());
   }
 
-  public Event.EventBuilder createException() {
+  public Event.EventBuilder createError() {
     return createEvent().type(EventType.ERROR.value());
   }
 
@@ -108,23 +122,23 @@ public CompletableFuture<Void> submitUnhandledExceptionAsync(
   }
 
   public void submitUnhandledException(Exception exception, String submissionMethod) {
-    Event event = createException().build();
+    Event event = createError().build();
     PluginContext pluginContext =
         PluginContext.builder()
             .exception(exception)
             .unhandledError(true)
             .submissionMethod(submissionMethod)
             .build();
-    submitEvent(EventPluginContext.builder().event(event).context(pluginContext).build());
+    submitEventWithContext(
+        EventPluginContext.builder().event(event).context(pluginContext).build());
   }
 
   public CompletableFuture<Void> submitFeatureUsageAsync(String feature) {
     return CompletableFuture.runAsync(() -> submitFeatureUsage(feature), executorService);
   }
 
   public void submitFeatureUsage(String feature) {
-    Event event = createFeatureUsage(feature).build();
-    submitEvent(EventPluginContext.from(event));
+    submitEvent(createFeatureUsage(feature).build());
   }
 
   public Event.EventBuilder createFeatureUsage(String feature) {
@@ -152,8 +166,7 @@ public CompletableFuture<Void> submitLogAsync(String message, String source, Str
   }
 
   public void submitLog(String message, String source, String level) {
-    Event event = createLog(message, source, level).build();
-    submitEvent(EventPluginContext.from(event));
+    submitEvent(createLog(message, source, level).build());
   }
 
   public Event.EventBuilder createLog(String message) {
@@ -166,13 +179,7 @@ public Event.EventBuilder createLog(String message, String source) {
 
   public Event.EventBuilder createLog(String message, String source, String level) {
     if (source == null) {
-      // Calling method
-      StackTraceElement[] traceElements = Thread.currentThread().getStackTrace();
-      source = traceElements[2].getMethodName();
-      // Came from the overrided method
-      if (source.equals("createLog")) {
-        source = traceElements[3].getMethodName();
-      }
+      source = getCallingMethod();
     }
 
     Event.EventBuilder builder =
@@ -184,13 +191,20 @@ public Event.EventBuilder createLog(String message, String source, String level)
     return builder.property(EventPropertyKey.LOG_LEVEL.value(), level);
   }
 
+  private String getCallingMethod() {
+    StackTraceElement[] traceElements = Thread.currentThread().getStackTrace();
+    String source = traceElements[3].getMethodName();
+    boolean cameFromOverridenMethod = source.equals("createLog");
+
+    return cameFromOverridenMethod ? traceElements[4].getMethodName() : source;
+  }
+
   public CompletableFuture<Void> submitNotFoundAsync(String resource) {
     return CompletableFuture.runAsync(() -> submitNotFound(resource), executorService);
   }
 
   public void submitNotFound(String resource) {
-    Event event = createNotFound(resource).build();
-    submitEvent(EventPluginContext.from(event));
+    submitEvent(createNotFound(resource).build());
   }
 
   public Event.EventBuilder createNotFound(String resource) {
@@ -202,8 +216,7 @@ public CompletableFuture<Void> submitSessionStartAsync() {
   }
 
   public void submitSessionStart() {
-    Event event = createSessionStart().build();
-    submitEvent(EventPluginContext.from(event));
+    submitEvent(createSessionStart().build());
   }
 
   public Event.EventBuilder createSessionStart() {
@@ -216,11 +229,21 @@ public Event.EventBuilder createEvent() {
         .date(LocalDate.now());
   }
 
-  public CompletableFuture<Void> submitEventAsync(EventPluginContext eventPluginContext) {
-    return CompletableFuture.runAsync(() -> submitEvent(eventPluginContext), executorService);
+  public CompletableFuture<Void> submitEventAsync(Event event) {
+    return CompletableFuture.runAsync(() -> submitEvent(event), executorService);
+  }
+
+  public void submitEvent(Event event) {
+    eventPluginRunner.run(EventPluginContext.from(event));
+  }
+
+  public CompletableFuture<Void> submitEventWithContextAsync(
+      EventPluginContext eventPluginContext) {
+    return CompletableFuture.runAsync(
+        () -> submitEventWithContext(eventPluginContext), executorService);
   }
 
-  public void submitEvent(EventPluginContext eventPluginContext) {
+  public void submitEventWithContext(EventPluginContext eventPluginContext) {
     eventPluginRunner.run(eventPluginContext);
   }
 

src/main/java/com/exceptionless/exceptionlessclient/settings/SettingsManager.java

@@ -97,7 +97,10 @@ private boolean shouldNotUpdate(SettingsResponse response) {
       return true;
     }
     if (!response.isSuccess()) {
-      LOG.warn(String.format("Unable to update settings: %s", response.getBody()));
+      LOG.warn(
+          String.format(
+              "Unable to update settings, body: %s, code: %s",
+              response.getBody(), response.getCode()));
       return true;
     }
     if (response.getSettings() == null) {

src/test/java/com/exceptionless/exceptionlessclient/ExceptionlessClientTest.java

@@ -86,7 +86,7 @@ public void itCanSubmitAnExceptionEvent() {
   public void itCanCreateAnExceptionEvent() {
     doReturn(settingsStorage).when(storageProvider).getSettings();
 
-    Event event = client.createException().build();
+    Event event = client.createError().build();
 
     assertThat(event.getType()).isEqualTo(EventType.ERROR.value());
     assertThat(event.getDate()).isNotNull();