Moved error parsing logic to plugin

Author: pc9795

src/main/java/com/exceptionless/exceptionlessclient/configuration/ConfigurationManager.java

@@ -35,7 +35,6 @@ public class ConfigurationManager {
   private static final Integer API_KEY_MIN_LENGTH = 11;
   private static final Integer DEFAULT_HEART_BEAT_INTERVAL_IN_SECS = 30;
 
-  @Getter private final ErrorParserIF errorParser;
   @Getter private final LastReferenceIdManagerIF lastReferenceIdManager;
   @Getter private final SubmissionClientIF submissionClient;
   @Getter private final EventQueueIF queue;
@@ -52,7 +51,6 @@ public class ConfigurationManager {
 
   @Builder
   public ConfigurationManager(
-      ErrorParserIF errorParser,
       LastReferenceIdManagerIF lastReferenceIdManager,
       LogCapturerIF logCatpurer,
       SubmissionClientIF submissionClient,
@@ -62,7 +60,6 @@ public ConfigurationManager(
       Configuration configuration,
       Integer maxQueueItems,
       Integer processingIntervalInSecs) {
-    this.errorParser = errorParser == null ? DefaultErrorParser.builder().build() : errorParser;
     this.lastReferenceIdManager =
         lastReferenceIdManager == null
             ? DefaultLastReferenceIdManager.builder().build()

src/main/java/com/exceptionless/exceptionlessclient/plugins/preconfigured/EnvironmentInfoPlugin.java

@@ -6,7 +6,7 @@
 import com.exceptionless.exceptionlessclient.models.enums.EnvironmentInfoPropertyKey;
 import com.exceptionless.exceptionlessclient.models.services.EnvironmentInfo;
 import com.exceptionless.exceptionlessclient.plugins.EventPluginIF;
-import com.exceptionless.exceptionlessclient.services.EnvironmentInfoGetArgs;
+import com.exceptionless.exceptionlessclient.plugins.preconfigured.args.EnvironmentInfoGetArgs;
 import com.sun.management.OperatingSystemMXBean;
 import lombok.Builder;
 import lombok.extern.slf4j.Slf4j;
@@ -67,7 +67,7 @@ public void run(
     }
   }
 
-  public EnvironmentInfo getEnvironmentInfo(EnvironmentInfoGetArgs args) {
+  private EnvironmentInfo getEnvironmentInfo(EnvironmentInfoGetArgs args) {
     OperatingSystemMXBean operatingSystemMXBean =
         (OperatingSystemMXBean) ManagementFactory.getOperatingSystemMXBean();
 

src/main/java/com/exceptionless/exceptionlessclient/plugins/preconfigured/ErrorPlugin.java

@@ -5,12 +5,13 @@
 import com.exceptionless.exceptionlessclient.models.EventPluginContext;
 import com.exceptionless.exceptionlessclient.models.enums.EventPropertyKey;
 import com.exceptionless.exceptionlessclient.models.enums.EventType;
+import com.exceptionless.exceptionlessclient.models.services.error.Error;
+import com.exceptionless.exceptionlessclient.models.services.error.StackFrame;
 import com.exceptionless.exceptionlessclient.plugins.EventPluginIF;
 import lombok.Builder;
 
-import java.util.HashSet;
-import java.util.Map;
-import java.util.Set;
+import java.util.*;
+import java.util.stream.Collectors;
 
 public class ErrorPlugin implements EventPluginIF {
   private static final Integer DEFAULT_PRIORITY = 30;
@@ -37,9 +38,30 @@ public void run(
       return;
     }
 
-    event.addError(configurationManager.getErrorParser().parse(exception));
+    event.addError(parse(exception));
 
     Set<String> dataExclusions = new HashSet<>(configurationManager.getDataExclusions());
     event.addData(Map.of(EventPropertyKey.EXTRA.value(), exception), dataExclusions);
   }
+
+  private Error parse(Exception exception) {
+    return Error.builder()
+        .type(exception.getClass().getCanonicalName())
+        .message(exception.getMessage())
+        .stackTrace(getStackFrames(exception))
+        .build();
+  }
+
+  private List<StackFrame> getStackFrames(Exception exception) {
+    return Arrays.stream(exception.getStackTrace())
+        .map(
+            stackTraceElement ->
+                StackFrame.builder()
+                    .name(stackTraceElement.getMethodName())
+                    .filename(stackTraceElement.getFileName())
+                    .lineNumber(stackTraceElement.getLineNumber())
+                    .declaringType(stackTraceElement.getClassName())
+                    .build())
+        .collect(Collectors.toList());
+  }
 }

src/main/java/com/exceptionless/exceptionlessclient/plugins/preconfigured/RequestInfoPlugin.java

@@ -5,7 +5,7 @@
 import com.exceptionless.exceptionlessclient.models.EventPluginContext;
 import com.exceptionless.exceptionlessclient.models.services.RequestInfo;
 import com.exceptionless.exceptionlessclient.plugins.EventPluginIF;
-import com.exceptionless.exceptionlessclient.services.RequestInfoGetArgs;
+import com.exceptionless.exceptionlessclient.plugins.preconfigured.args.RequestInfoGetArgs;
 import com.exceptionless.exceptionlessclient.utils.Utils;
 import lombok.Builder;
 import lombok.extern.slf4j.Slf4j;
@@ -65,7 +65,7 @@ public void run(
     event.addRequestInfo(requestInfo);
   }
 
-  public RequestInfo getRequestInfo(HttpRequest request, RequestInfoGetArgs args) {
+  private RequestInfo getRequestInfo(HttpRequest request, RequestInfoGetArgs args) {
     RequestInfo.RequestInfoBuilder<?, ?> builder =
         RequestInfo.builder()
             .userAgent(request.headers().firstValue("User-Agent").orElse(null))

src/main/java/com/exceptionless/exceptionlessclient/services/EnvironmentInfoGetArgs.java renamed to src/main/java/com/exceptionless/exceptionlessclient/plugins/preconfigured/args/EnvironmentInfoGetArgs.java

@@ -1,4 +1,4 @@
-package com.exceptionless.exceptionlessclient.services;
+package com.exceptionless.exceptionlessclient.plugins.preconfigured.args;
 
 import lombok.Builder;
 import lombok.Value;

src/main/java/com/exceptionless/exceptionlessclient/services/RequestInfoGetArgs.java renamed to src/main/java/com/exceptionless/exceptionlessclient/plugins/preconfigured/args/RequestInfoGetArgs.java

@@ -1,4 +1,4 @@
-package com.exceptionless.exceptionlessclient.services;
+package com.exceptionless.exceptionlessclient.plugins.preconfigured.args;
 
 import lombok.Builder;
 import lombok.Value;

src/main/java/com/exceptionless/exceptionlessclient/services/DefaultErrorParser.java

@@ -22,19 +22,19 @@ public void itCanSendChangesToListeners() {
         PrivateInformationInclusions.builder().build();
     privateInformationInclusions.addPropertyChangeListener(listener);
 
-    privateInformationInclusions.applyToAll(false);
-    privateInformationInclusions.setQueryString(true);
-    privateInformationInclusions.setPostData(true);
-    privateInformationInclusions.setCookies(true);
-    privateInformationInclusions.setIpAddress(true);
-    privateInformationInclusions.setMachineName(true);
-    privateInformationInclusions.setUserName(true);
+    privateInformationInclusions.applyToAll(true);
+    privateInformationInclusions.setQueryString(false);
+    privateInformationInclusions.setPostData(false);
+    privateInformationInclusions.setCookies(false);
+    privateInformationInclusions.setIpAddress(false);
+    privateInformationInclusions.setMachineName(false);
+    privateInformationInclusions.setUserName(false);
 
     List<String> properties =
         List.of(
             "all", "queryString", "postData", "cookies", "ipAddress", "machineName", "userName");
-    List<Boolean> oldValues = List.of(true, false, false, false, false, false, false);
-    List<Boolean> newValues = List.of(false, true, true, true, true, true, true);
+    List<Boolean> oldValues = List.of(false, true, true, true, true, true, true);
+    List<Boolean> newValues = List.of(true, false, false, false, false, false, false);
 
     properties.forEach(
         property ->