Skip to content

addData method in Event class should take configuration data inclusions into consideration #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
pc9795 opened this issue Nov 30, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@pc9795
Copy link
Collaborator

pc9795 commented Nov 30, 2021

Right now we have this method signature to add data once an Event object is created

public void addData(Map<String, Object> data, Set<String> dataExclusions) {

It explicitly asks for data exclusions with the data and doesn't take the configuration default data exclusion into consideration

  • We should provide an override for this method which only uses configuration default data exclusions
  • We should be combining the provided data exclusions with configuration defaults.
@pc9795 pc9795 added the bug Something isn't working label Nov 30, 2021
@niemyjski
Copy link
Member

Nice find!

@pc9795
Copy link
Collaborator Author

pc9795 commented Nov 18, 2023

Closing as WAD

@pc9795 pc9795 closed this as completed Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants