Fixed a bug where byte filters wasn't parsing string numbers.

Author: niemyjski

CHANGELOG

@@ -17,10 +17,12 @@ Prints a number in a friendly byte representation<br/>
 
 ```html
 {{1536 | bytes}}
+{{'1536' | bytes}}
 {{1536 | bytes:2}}
 
 Result:
 1.5 kB
+1.5 kB
 1.50 kB
 ```
 

README.md

@@ -1,6 +1,6 @@
 {
   "name": "angular-filters",
-  "version": "1.1.1",
+  "version": "1.2.0",
   "main": "./dist/angular-filters.min.js",
   "description": "Useful filters for AngularJS",
   "repository": {
@@ -9,7 +9,7 @@
   },
   "dependencies": {
     "angular": ">=1.3.x",
-    "angular-mocks": "~1.3.7"
+    "angular-mocks": ">=1.3.x"
   },
   "ignore": [
     "node_modules"

bower.json

@@ -1,6 +1,6 @@
 /**
  * Useful filters for AngularJS
- * @version v1.1.1 - 2014-11-18 * @link https://github.com/niemyjski/angular-filters
+ * @version v1.2.0 - 2015-01-30 * @link https://github.com/exceptionless/angular-filters
  * @author Blake Niemyjski <[email protected]>
  * @license MIT License, http://www.opensource.org/licenses/MIT
  */(function () {
@@ -15,11 +15,13 @@
     angular.module('angular-filters')
         .filter('bytes', [function () {
             return function(bytes, precision) {
-                if (bytes === 0) {
-                    return '0 B';
+                if (typeof bytes !== 'number') {
+                    bytes = parseFloat(bytes);
                 }
 
-                if (isNaN(parseFloat(bytes)) || !isFinite(bytes)) {
+                if (bytes === 0) {
+                    return '0 B';
+                } else if (isNaN(bytes) || !isFinite(bytes)) {
                     return '-';
                 }
 
@@ -28,7 +30,11 @@
                     bytes = -bytes;
                 }
 
-                if (typeof precision === 'undefined') {
+                if (typeof precision !== 'number') {
+                    precision = parseFloat(precision);
+                }
+
+                if (isNaN(precision) || !isFinite(precision)) {
                     precision = 1;
                 }
 

dist/angular-filters.js

@@ -1,14 +1,14 @@
 {
   "name": "angular-filters",
   "description": "Useful filters for AngularJS",
-  "version": "1.1.1",
+  "version": "1.2.0",
   "filename": "angular-filters.min.js",
   "main": "./dist/angular-filters.min.js",
-  "homepage": "https://github.com/niemyjski/angular-filters",
+  "homepage": "https://github.com/exceptionless/angular-filters",
   "author": "Blake Niemyjski <[email protected]>",
   "repository": {
     "type": "git",
-    "url": "git://github.com/niemyjski/angular-filters.git"
+    "url": "git://github.com/exceptionless/angular-filters.git"
   },
   "engines": {
     "node": ">= 0.9"

dist/angular-filters.min.js

@@ -17,6 +17,18 @@ describe('Filter: bytes', function() {
         expect(byte(size, 2)).toBe('1.50 kB');
     });
 
+    it('should parse string numbers into byte', function () {
+        expect(byte('0', 0)).toBe('0 B');
+        expect(byte('10', 0)).toBe('10 B');
+
+        var size = 1024 + 512;
+        expect(byte(size, '2')).toBe('1.50 kB');
+    });
+
+    it('should recognize zero byte', function () {
+        expect(byte(0, 0)).toBe('0 B');
+    });
+
     it('should recognize negative byte', function () {
         expect(byte(-1, 0)).toBe('-1 B');
     });

package.json

@@ -4,11 +4,13 @@
     angular.module('angular-filters')
         .filter('bytes', [function () {
             return function(bytes, precision) {
-                if (bytes === 0) {
-                    return '0 B';
+                if (typeof bytes !== 'number') {
+                    bytes = parseFloat(bytes);
                 }
 
-                if (isNaN(parseFloat(bytes)) || !isFinite(bytes)) {
+                if (bytes === 0) {
+                    return '0 B';
+                } else if (isNaN(bytes) || !isFinite(bytes)) {
                     return '-';
                 }
 
@@ -17,7 +19,11 @@
                     bytes = -bytes;
                 }
 
-                if (typeof precision === 'undefined') {
+                if (typeof precision !== 'number') {
+                    precision = parseFloat(precision);
+                }
+
+                if (isNaN(precision) || !isFinite(precision)) {
                     precision = 1;
                 }