|
| 1 | +# How to give great feedback |
| 2 | + |
| 3 | +At this stage you should have chosen a solution to mentor. |
| 4 | +If you've not, work your way through [Choosing a solution to mentor](./choosing-a-solution) first, then come back here. |
| 5 | + |
| 6 | +## Your first feedback |
| 7 | + |
| 8 | +You're now about to give your first feedback to a student. |
| 9 | +This can be exciting but also pretty daunting. |
| 10 | +A lot of (the best!) mentors suffer from [Impostor Syndrome](https://en.wikipedia.org/wiki/Impostor_syndrome) at this stage, and give up before they start. |
| 11 | +If you feel like that, it's totally understandable, but also almost always unnecessary. |
| 12 | +By the fact you're worrying about whether your feedback is going to be good enough, it's likely that you'll give thoughtful humble comments that students really appreciate. |
| 13 | +And in the worst case, a student can always end the discussion, and wait for another mentor, so let's give it a go! |
| 14 | + |
| 15 | +## Mindset |
| 16 | + |
| 17 | +The first thing to keep in mind is having the right mindset as a mentor. |
| 18 | +Students are hoping you can help improve their knowledge, and tell them things that they don't know. |
| 19 | +Your job isn't to "mark" their work, it's to use their solution as a basis for unlocking ideas that they are not familiar with or are struggling with. |
| 20 | + |
| 21 | +It's also worth remembering that most Exercism users are experienced developers learning a new language. |
| 22 | +So although their code might look bad, that may well be because they don't know how to write this language. |
| 23 | +Similar code in a different language might be totally idiomatic and correct. |
| 24 | +Conversations tend to go much better when they are approached as two peers discussing a topic, rather than one person showing off their knowledge to another. |
| 25 | + |
| 26 | +## Addressing the student's request vs teaching a new idea |
| 27 | + |
| 28 | +When a student submits a solution for mentoring, they are promoted to tell the mentor what they are hoping to get from it. |
| 29 | +It's really important that you as the mentor read that and try and address it in your feedback. |
| 30 | + |
| 31 | +However, one of the key values of mentoring on Exercism is that mentors can help students discover ideas they had no idea about. |
| 32 | +So you might look at a student's solution, read their comment which asks if there are any tweaks they could make, and think "Wow - you really don't have a grasp on this exercise at all". |
| 33 | +It might be that they've totally missed the point of the exercise. |
| 34 | +In your time as a mentor, you'll see some incredibly "overfit" solutons where students make the tests pass but totally miss the point of the challenge. |
| 35 | +Or see incredibly complex solutions that can be rewritten in a couple of lines of code. |
| 36 | + |
| 37 | +Your job as a mentor is to help take the student forward **from where they start**. |
| 38 | +What's the biggest thing you could do to help unlock an idea or unblock your thinking? |
| 39 | +You'll find that if you can explain an idea to a student and set a lightbulb off in their head, it'll be an incredibly rewarding discussion. |
| 40 | + |
| 41 | +## Don't just give the solution away |
| 42 | + |
| 43 | +The aim in mentoring is **not** for a student to get to the optimal solution, it is for a student to learn new things. |
| 44 | +Simply giving a student the correct answer is neither useful nor helpful. |
| 45 | +Exercism encourages students to go and look at other people's solutions and learn from them, so you giving them a good solution doesn't add any value. |
| 46 | +The value you add as a mentor is helping them think differently, helping them see things in a different light. |
| 47 | + |
| 48 | +Different mentors have different approaches to whether they give "hints" or "explanations". |
| 49 | +As a general rule, aim for somewhere between the two. |
| 50 | +Ensure that you tell the student enough that they can understand what they should try, but try not to just give them the answer and tell them why it works. |
| 51 | + |
| 52 | +For example, let's imagine you see an `if` statement in Ruby that would be much more nicely written using the [ternary operator](https://en.wikipedia.org/wiki/%3F:): |
| 53 | + |
| 54 | +``` |
| 55 | +# Student's code |
| 56 | +if a |
| 57 | + b = 1 |
| 58 | +else |
| 59 | + b = 2 |
| 60 | +end |
| 61 | +
|
| 62 | +# Mentor's suggestion |
| 63 | +b = a ? 1 : 2 |
| 64 | +``` |
| 65 | + |
| 66 | +You could just say "Write `b = a ? 1 : 2` instead of the `if` statement on L10. |
| 67 | +But that wouldn't be helping a student understand the why or have a lightbulb moment of their own. |
| 68 | + |
| 69 | +Instead it would be much better to introduce the idea of a ternary, and pose the student a challenge. |
| 70 | +For example: "I think you could reduce the Lines 10-14 down to one line using the Ternary Operator. How might that look?" |
| 71 | +A student will then have to play with that and solve it themselves, but you've given them enough info to work with. |
| 72 | + |
| 73 | +On the other end of the scale, saying "Reduce lines 10-14 to one line" wouldn't give a student any indication of how that's achievable, and so could be incredibly frustrating for them. |
| 74 | +So try to ensure you give enough information for a student to progress. |
| 75 | + |
| 76 | +## How much feedback should you give |
| 77 | + |
| 78 | +Different mentors have different styles, but our default suggestion is to give the most important one to three pieces of feedback on any iteration. |
| 79 | +If the student submits a new iteration with those solved, then you could give another one to three pieces of feedback. |
| 80 | +By breaking things up in that way, a student will not feel overwhelmed, but will also have enough to do to make meaningful changes each time. |
| 81 | + |
| 82 | +As you gain experience mentoring, you will get a feel for the different ways students react to different feedback, and develop a style that fits your personality. |
| 83 | + |
| 84 | +## Unsure of something? Chat to other mentors? |
| 85 | + |
| 86 | +One of the best things about being an Exercism mentor, is the community of other mentors you can learn from. |
| 87 | +If you've got a question about a solution, or just want to bounce ideas with other mentors, jump into our [Slack Room]() and ask away! |
| 88 | +You'll probably find people you can help there too 🙂 |
0 commit comments