Skip to content

Commit 8ba3021

Browse files
authored
remove use std::ascii::AsciiExt for Rust 1.23 (#411)
In Rust 1.23, the `AsciiExt` methods are implemented directly on the concerned types, so attempting to import `AsciiExt` results in an unused import. Rust language PR: rust-lang/rust#44042 PSA: https://users.rust-lang.org/t/psa-dealing-with-warning-unused-import-std-ascii-asciiext-in-today-s-nightly/13726 This started warning as an unused import on nightly sometime between 2017-11-02 and 2017-11-09: https://travis-ci.org/exercism/rust/builds/296391447 https://travis-ci.org/exercism/rust/builds/299770403 This started warning on beta exactly when 1.23.0 became Beta (it was accepted on 1.22.0): https://travis-ci.org/exercism/rust/builds/303139434 https://travis-ci.org/exercism/rust/builds/306431846 As 1.23 is now stable and our repo disallows warnings on stable, we will need this.
1 parent 1e39915 commit 8ba3021

File tree

5 files changed

+0
-7
lines changed

5 files changed

+0
-7
lines changed

exercises/atbash-cipher/example.rs

-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
use std::ascii::AsciiExt;
2-
31
fn ascii(ch: char) -> u8 {
42
ch as u8
53
}

exercises/crypto-square/example.rs

-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
use std::ascii::AsciiExt;
2-
31
extern crate itertools;
42
use itertools::Itertools;
53

exercises/etl/example.rs

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
use std::ascii::AsciiExt;
21
use std::collections::BTreeMap;
32

43
pub fn transform(input: &BTreeMap<i32, Vec<char>>) -> BTreeMap<char, i32> {

exercises/forth/example.rs

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
use std::ascii::AsciiExt;
21
use std::collections::HashMap;
32
use std::collections::LinkedList;
43
use std::str::FromStr;

exercises/pangram/example.rs

-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
use std::collections::BTreeSet;
2-
use std::ascii::AsciiExt;
32
use std::iter::FromIterator;
43

54
pub fn is_pangram(sentence: &str) -> bool {

0 commit comments

Comments
 (0)