Upgrade to Yarn 4 & Add PnP Support (#72)

* Upgrade to Yarn 4

* Upgrade workflows

* Bump actions

* Cleanup ignore for prettier & Update dep

* Use immutable flag

* Explicitly add core-js

* Forcefully disable global cache

* Let's ignore production-only build for now

* Allow logging on re-run

* Disable hardened mode when disabling network

* Disable network in docker file for yarn and corepack

* Switch from yarnPath to corepack

* Show us the generated results.json

* Rely on local yarn

* Force corepack usage

* Ignore format for .vscode files

* Annotate global cache usage

Author: SleeplessByte

.eslintignore

@@ -12,7 +12,7 @@ jobs:
     steps:
       - name: 'Post acknowledgement that it will format code'
         continue-on-error: true # Never fail the build if this fails
-        uses: actions/github-script@d7906e4ad0b1822421a7e6a35d5ca353c962f410
+        uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |
@@ -60,12 +60,10 @@ jobs:
           git clone $HEAD_REPO .
           git checkout -b "$HEAD_REF" "origin/$HEAD_REF"
 
-      - name: Use Node.js LTS (18.x)
-        uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c
+      - name: Use Node.js LTS (20.x)
+        uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b
         with:
-          node-version: '18'
-      - name: Install project development dependencies
-        run: npm install --no-save
+          node-version: 20.x
       - name: 'Format code'
         run: ./bin/format.sh
 
@@ -88,7 +86,7 @@ jobs:
 
       - name: 'Post acknowledgement that it has formatted the code'
         continue-on-error: true # Never fail the build if this fails
-        uses: actions/github-script@d7906e4ad0b1822421a7e6a35d5ca353c962f410
+        uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |
@@ -102,7 +100,7 @@ jobs:
       - name: 'Post reminder to trigger build manually'
         continue-on-error: true # Never fail the build if this fails
         if: steps.fork_status.outputs.fork == 'true'
-        uses: actions/github-script@d7906e4ad0b1822421a7e6a35d5ca353c962f410
+        uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |

.eslintrc.js

@@ -14,12 +14,15 @@ jobs:
     steps:
       - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
       - name: Use Node.js LTS
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b
         with:
           node-version-file: .nvmrc
 
       - name: Install project dependencies
-        run: yarn install --frozen-lockfile
+        run: |
+          corepack enable yarn
+          corepack yarn -v
+          corepack yarn install --immutable
 
       - name: Run exercism/typescript-test-runner ci precheck (lint code)
         run: bin/lint.sh
@@ -34,12 +37,15 @@ jobs:
     steps:
       - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b
         with:
           node-version: ${{ matrix.node-version }}
 
       - name: Install project dependencies
-        run: yarn install --frozen-lockfile
+        run: |
+          corepack enable yarn
+          corepack yarn -v
+          corepack yarn install --immutable
 
       - name: Build the test-runner (using Node ${{ matrix.node-version }})
         run: bin/test.sh

.github/workflows/action-format.yml

@@ -11,15 +11,18 @@ jobs:
 
     steps:
       - name: Checkout PR
-        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
+        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
 
       - name: Use Node.js LTS
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b
         with:
           node-version-file: .nvmrc
 
       - name: Install project dependencies
-        run: yarn install --frozen-lockfile
+        run: |
+          corepack enable yarn
+          corepack yarn -v
+          corepack yarn install --immutable
 
       - name: Run exercism/javascript ci precheck (lint code)
         run: bin/lint.sh
@@ -41,7 +44,10 @@ jobs:
           node-version: ${{ matrix.node-version }}
 
       - name: Install project dependencies
-        run: yarn install --frozen-lockfile
+        run: |
+          corepack enable yarn
+          corepack yarn -v
+          corepack yarn install --immutable
 
       - name: Build the test-runner (using Node ${{ matrix.node-version }})
         run: bin/test.sh

.github/workflows/ci.js.yml

@@ -10,7 +10,7 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - name: 'Checkout code'
-        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
+        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
 
       - name: 'Verify formatting of all files'
         run: ./bin/check-formatting.sh

.github/workflows/pr.ci.js.yml

@@ -1,17 +1,14 @@
-/.github/labels.yml
-/.github/workflows/sync-labels.yml
-/test/fixtures
+/test/fixtures/**/*
 /tmp
 /dist
 /node_modules
-/CODE_OF_CONDUCT.md
 
 /.yarn
 /.yarnrc.yml
+/.vscode
 
 # These are org-wide files (https://github.com/exercism/org-wide-files/)
 /.github/labels.yml
 /.github/workflows/sync-labels.yml
-
 /CODE_OF_CONDUCT.md
 /LICENSE

.github/workflows/verify-code-formatting.yml

@@ -0,0 +1,7 @@
+{
+  "recommendations": [
+    "arcanis.vscode-zipfs",
+    "dbaeumer.vscode-eslint",
+    "esbenp.prettier-vscode"
+  ]
+}

.prettierignore

@@ -0,0 +1,10 @@
+{
+  "search.exclude": {
+    "**/.yarn": true,
+    "**/.pnp.*": true
+  },
+  "eslint.nodePath": ".yarn/sdks",
+  "prettier.prettierPath": ".yarn/sdks/prettier/index.cjs",
+  "typescript.tsdk": ".yarn/sdks/typescript/lib",
+  "typescript.enablePromptUseWorkspaceTsdk": true
+}