Add base_url parameter to embedding_factory for custom endpoint support #2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
anistark
approved these changes
Aug 26, 2025
Member
There was a problem hiding this comment.
It's a good to have. Thanks for the PR @KoLogicDev 🎉
However, merged is blocked by conflicts. Please rebase and get those sorted.
Member
|
Taken up in #2303 |
anistark
added a commit
that referenced
this pull request
Sep 23, 2025
## Issue Link / Problem Description <!-- Link to related issue or describe the problem this PR solves --> - contd #2019 Co-authored-by: Stepan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a base_url parameter to the embedding_factory function, allowing users to specify a custom API endpoint for the embedding model. This is particularly useful when working with OpenAI-compatible APIs hosted on private or self-hosted infrastructure.
Changes
Motivation
Enables greater flexibility when using embedding_factory, such as routing requests to non-default or local endpoints.
Notes
No breaking changes introduced. Default behavior remains unchanged when base_url is not provided.