fix: skip creating a git repo when inside existing repo (#920)

* test: skip creating a git repo when inside existing repo

* fix: skip creating git repo inside existing repo

* test: use proper paths for project files

* test: use absolute paths when checking existence to avoid quantum tangling multiple dimensions and causing the universe to stop existing

Author: byCedric

__tests__/index-test.js

@@ -141,6 +141,29 @@ describe('yes', () => {
     expect(fileExists(projectName, '.gitignore')).toBeTruthy();
     expect(fileExists(projectName, 'node_modules')).not.toBeTruthy();
   });
+  it('does not create a new git repository inside an existing repository', async () => {
+    const workspaceName = 'yes-skip-git-in-repo';
+    const workspaceRoot = getRoot(workspaceName);
+
+    // Create the workspace root, and basic monorepo structure
+    await fs.mkdirp(workspaceRoot);
+    await execa('git', ['init'], { cwd: workspaceRoot });
+
+    // Create the app within a basic monorepo structure
+    const projectRoot = path.join(workspaceRoot, 'apps', workspaceName);
+    await fs.mkdirp(projectRoot);
+
+    const results = await execa('node', [cli, '--yes'], { cwd: projectRoot });
+    expect(results.exitCode).toBe(0);
+
+    expect(existsSync(path.join(workspaceRoot, '.git'))).toBe(true);
+    expect(existsSync(path.join(projectRoot, '.git'))).not.toBe(true);
+
+    expect(existsSync(path.join(projectRoot, 'package.json'))).toBe(true);
+    expect(existsSync(path.join(projectRoot, 'App.js'))).toBe(true);
+    expect(existsSync(path.join(projectRoot, '.gitignore'))).toBe(true);
+    expect(existsSync(path.join(projectRoot, 'node_modules'))).toBe(true);
+  });
 });
 
 describe('templates', () => {

src/Template.ts

@@ -110,6 +110,7 @@ export async function initGitRepoAsync(
   try {
     await spawnAsync('git', ['rev-parse', '--is-inside-work-tree'], { stdio: 'ignore', cwd: root });
     !flags.silent && Logger.gray('New project is already inside of a Git repo, skipping git init.');
+    return false;
   } catch (e) {
     if (e.errno === 'ENOENT') {
       !flags.silent && Logger.gray('Unable to initialize Git repo. `git` not in PATH.');