Clang format newline (#29)

* using same clang format binary than faasm

* applied new clang-format to all codebase

* adding newline at the end of the bash script

Author: csegarragonz

Diff for: bin/run_clang_format.sh

@@ -2,6 +2,14 @@
 
 set -e
 
+function append_newline {
+    if [[ -z "$(tail -c 1 "$1")" ]]; then
+        :
+    else
+        echo >> "$1"
+    fi
+}
+
 if [ -z "$1" ]; then
     TARGET_DIR="."
 else
@@ -11,7 +19,15 @@ fi
 pushd ${TARGET_DIR} >> /dev/null
 
 # Find all source files using Git to automatically respect .gitignore
-clang-format-10 -i $(git ls-files "*.h" "*.cpp" "*.c") 
+FILES=$(git ls-files "*.h" "*.cpp" "*.c")
+
+# Run clang-format
+clang-format-10 -i ${FILES}
+
+# Check newlines
+for f in ${FILES}; do
+    append_newline $f
+done
 
 popd >> /dev/null
 

Diff for: faabric.cpp

@@ -1 +1 @@
-// Stub to link together top-level CMake library
+// Stub to link together top-level CMake library

Diff for: include/faabric/executor/FaabricExecutor.h

@@ -59,4 +59,4 @@ class FaabricExecutor
                     bool success,
                     const std::string& errorMsg);
 };
-}
+}

Diff for: include/faabric/executor/FaabricMain.h

@@ -21,4 +21,4 @@ class FaabricMain
 
     faabric::executor::FaabricPool& pool;
 };
-}
+}

Diff for: include/faabric/proto/RPCServer.h

@@ -28,4 +28,4 @@ class RPCServer
 
     virtual void doStart(const std::string& serverAddr) = 0;
 };
-}
+}

Diff for: include/faabric/proto/macros.h

@@ -12,4 +12,4 @@
 #define DEFAULT_RPC_HOST "0.0.0.0"
 #define STATE_PORT 8003
 #define FUNCTION_CALL_PORT 8004
-#define MPI_MESSAGE_PORT 8005
+#define MPI_MESSAGE_PORT 8005

Diff for: include/faabric/scheduler/ExecGraph.h

@@ -20,4 +20,4 @@ int countExecGraphNodes(const ExecGraph& graph);
 std::string execNodeToJson(const ExecGraphNode& node);
 
 std::string execGraphToJson(const ExecGraph& graph);
-}
+}

Diff for: include/faabric/scheduler/FunctionCallClient.h

@@ -28,4 +28,4 @@ class FunctionCallClient
 
     void sendMPIMessage(const faabric::MPIMessage& msg);
 };
-}
+}

Diff for: include/faabric/scheduler/FunctionCallServer.h

@@ -30,4 +30,4 @@ class FunctionCallServer final
   private:
     Scheduler& scheduler;
 };
-}
+}

Diff for: include/faabric/scheduler/InMemoryMessageQueue.h

@@ -6,4 +6,4 @@
 namespace faabric::scheduler {
 typedef faabric::util::Queue<faabric::Message> InMemoryMessageQueue;
 typedef std::pair<std::string, InMemoryMessageQueue*> InMemoryMessageQueuePair;
-}
+}

Diff for: include/faabric/scheduler/MpiContext.h

@@ -24,4 +24,4 @@ class MpiContext
     int rank;
     int worldId;
 };
-}
+}

Diff for: include/faabric/scheduler/Scheduler.h

@@ -132,4 +132,4 @@ class Scheduler
 };
 
 Scheduler& getScheduler();
-}
+}

Diff for: include/faabric/state/DummyStateServer.h

@@ -29,4 +29,4 @@ class DummyStateServer
     state::StateServer stateServer;
 };
 
-}
+}

Diff for: include/faabric/state/InMemoryStateRegistry.h

@@ -27,4 +27,4 @@ class InMemoryStateRegistry
 };
 
 InMemoryStateRegistry& getInMemoryStateRegistry();
-}
+}

Diff for: include/faabric/state/State.h

@@ -43,4 +43,4 @@ class State
 };
 
 State& getGlobalState();
-}
+}

Diff for: include/faabric/state/StateClient.h

@@ -54,4 +54,4 @@ class StateClient
 
     void unlock();
 };
-}
+}

Diff for: include/faabric/state/StateKeyValue.h

@@ -177,4 +177,4 @@ class StateKeyValueException : public std::runtime_error
       : runtime_error(message)
     {}
 };
-}
+}

Diff for: include/faabric/state/StateServer.h

@@ -59,4 +59,4 @@ class StateServer final
   private:
     State& state;
 };
-}
+}

Diff for: include/faabric/util/barrier.h

@@ -23,4 +23,4 @@ class Barrier
     std::mutex mx;
     std::condition_variable cv;
 };
-}
+}

Diff for: include/faabric/util/bytes.h

@@ -18,4 +18,4 @@ int safeCopyToBuffer(const uint8_t* dataIn,
                      int dataLen,
                      uint8_t* buffer,
                      int bufferLen);
-}
+}

Diff for: include/faabric/util/chaining.h

@@ -15,4 +15,4 @@ class ChainedCallFailedException : public faabric::util::FaabricException
       : FaabricException(std::move(message))
     {}
 };
-}
+}

Diff for: include/faabric/util/clock.h

@@ -22,4 +22,4 @@ class Clock
 };
 
 Clock& getGlobalClock();
-}
+}

Diff for: include/faabric/util/config.h

@@ -76,4 +76,4 @@ class SystemConfig
 };
 
 SystemConfig& getSystemConfig();
-}
+}

Diff for: include/faabric/util/environment.h

@@ -10,4 +10,4 @@ std::string setEnvVar(const std::string& varName, const std::string& value);
 void unsetEnvVar(const std::string& varName);
 
 unsigned int getUsableCores();
-}
+}

Diff for: include/faabric/util/exception.h

@@ -19,4 +19,4 @@ class FaabricException : public std::exception
   protected:
     std::string _message;
 };
-}
+}

Diff for: include/faabric/util/files.h

@@ -37,4 +37,4 @@ class FileAtUrlIsDirectoryException : public faabric::util::FaabricException
       : FaabricException(std::move(message))
     {}
 };
-}
+}

Diff for: include/faabric/util/gids.h

@@ -4,4 +4,4 @@
 
 namespace faabric::util {
 unsigned int generateGid();
-}
+}

Diff for: include/faabric/util/json.h

@@ -18,4 +18,4 @@ class JsonFieldNotFound : public faabric::util::FaabricException
 
 std::string getValueFromJsonString(const std::string& key,
                                    const std::string& jsonIn);
-}
+}

Diff for: include/faabric/util/locks.h

@@ -7,4 +7,4 @@ namespace faabric::util {
 typedef std::unique_lock<std::mutex> UniqueLock;
 typedef std::unique_lock<std::shared_mutex> FullLock;
 typedef std::shared_lock<std::shared_mutex> SharedLock;
-}
+}

Diff for: include/faabric/util/logging.h

@@ -6,4 +6,4 @@ namespace faabric::util {
 void initLogging();
 
 std::shared_ptr<spdlog::logger> getLogger();
-}
+}

Diff for: include/faabric/util/memory.h

@@ -25,4 +25,4 @@ size_t getRequiredHostPagesRoundDown(size_t nBytes);
 size_t alignOffsetDown(size_t offset);
 
 AlignedChunk getPageAlignedChunk(long offset, long length);
-}
+}

Diff for: include/faabric/util/network.h

@@ -8,4 +8,4 @@ namespace faabric::util {
 std::string getIPFromHostname(const std::string& hostname);
 
 std::string getPrimaryIPForThisHost(const std::string& interface);
-}
+}

Diff for: include/faabric/util/queue.h

@@ -98,4 +98,4 @@ class TokenPool
     int _size;
     Queue<int> queue;
 };
-}
+}

Diff for: include/faabric/util/random.h

@@ -6,4 +6,4 @@ namespace faabric::util {
 std::string randomString(int len);
 
 std::string randomStringFromSet(const std::unordered_set<std::string>& s);
-}
+}

Diff for: include/faabric/wasm/wasm.h

@@ -1,3 +1,3 @@
 #pragma once
 
-int helloFaabricWasm();
+int helloFaabricWasm();

Diff for: src/executor/FaabricExecutor.cpp

@@ -219,4 +219,4 @@ void FaabricExecutor::postFinish() {}
 
 void FaabricExecutor::postFlush() {}
 
-}
+}

Diff for: src/proto/RPCServer.cpp

@@ -50,4 +50,4 @@ void RPCServer::stop()
         }
     }
 }
-}
+}

Diff for: src/scheduler/FunctionCallClient.cpp

@@ -26,4 +26,4 @@ void FunctionCallClient::sendMPIMessage(const faabric::MPIMessage& msg)
     faabric::FunctionStatusResponse response;
     CHECK_RPC("mpi_message", stub->MPICall(&context, msg, &response));
 }
-}
+}

Diff for: src/scheduler/FunctionCallServer.cpp

@@ -66,4 +66,4 @@ Status FunctionCallServer::MPICall(ServerContext* context,
 
     return Status::OK;
 }
-}
+}

Diff for: src/scheduler/MpiContext.cpp

@@ -65,4 +65,4 @@ int MpiContext::getWorldId()
 {
     return worldId;
 }
-}
+}

Diff for: src/scheduler/MpiWorldRegistry.cpp

@@ -68,4 +68,4 @@ void MpiWorldRegistry::clear()
     faabric::util::FullLock lock(registryMutex);
     worldMap.clear();
 }
-}
+}

Diff for: src/scheduler/Scheduler.cpp

@@ -727,4 +727,4 @@ std::unordered_set<unsigned int> Scheduler::getChainedFunctions(
 
     return chainedIds;
 }
-}
+}

Diff for: src/state/DummyStateServer.cpp

@@ -94,4 +94,4 @@ void DummyStateServer::stop()
         serverThread.join();
     }
 }
-}
+}

Diff for: src/state/RedisStateKeyValue.cpp

@@ -143,4 +143,4 @@ void RedisStateKeyValue::clearAppendedFromRemote()
 {
     redis::Redis::getState().del(joinedKey);
 }
-}
+}

Diff for: src/state/StateClient.cpp

@@ -201,4 +201,4 @@ void StateClient::unlock()
     ClientContext context;
     CHECK_RPC("state_unlock", stub->Unlock(&context, request, &response))
 }
-}
+}

Diff for: src/state/StateKeyValue.cpp

@@ -630,4 +630,4 @@ std::vector<StateChunk> StateKeyValue::getDirtyChunks(
 
     return chunks;
 }
-}
+}

Diff for: src/util/barrier.cpp

@@ -39,4 +39,4 @@ int Barrier::getUseCount()
     return uses;
 }
 
-}
+}

Diff for: src/util/environment.cpp

@@ -44,4 +44,4 @@ unsigned int getUsableCores()
 
     return nCores;
 }
-}
+}

Diff for: src/util/gids.cpp

@@ -32,4 +32,4 @@ unsigned int generateGid()
         return intHash + counter.fetch_add(1);
     }
 }
-}
+}

Diff for: src/util/logging.cpp

@@ -39,4 +39,4 @@ std::shared_ptr<spdlog::logger> getLogger()
 
     return logger;
 }
-}
+}

Diff for: src/util/random.cpp

@@ -43,4 +43,4 @@ std::string randomStringFromSet(const std::unordered_set<std::string>& s)
 
     return *it;
 }
-}
+}

Diff for: src/util/timing.cpp

@@ -52,4 +52,4 @@ void nanosToTimespec(uint64_t nanos, struct timespec* nativeTimespec)
     nativeTimespec->tv_sec = nanos / 1000000000;
     nativeTimespec->tv_nsec = nanos % 1000000000;
 }
-}
+}

Diff for: tests/test/endpoint/test_handler.cpp

@@ -145,4 +145,4 @@ TEST_CASE("Check getting function status from endpoint", "[endpoint]")
 
     REQUIRE(actual == expectedOutput);
 }
-}
+}

Diff for: tests/test/main.cpp

@@ -13,4 +13,4 @@ int main(int argc, char* argv[])
     fflush(stdout);
 
     return result;
-}
+}