Update pyproject.toml and MANIFEST.in.

Author: fabiocaccamo

.github/workflows/test-package.yml

@@ -43,9 +43,7 @@ jobs:
 
     - name: Run tests
       run: |
-        coverage run --append --source=codicefiscale -m unittest
-        coverage report --show-missing
-        coverage xml -o ./coverage.xml
+        pytest tests --cov=codicefiscale --cov-report=term-missing --cov-fail-under=90
 
     - name: Upload coverage to Codecov
       uses: codecov/codecov-action@v4

MANIFEST.in

@@ -1,4 +1,5 @@
 include LICENSE.txt
 include README.md
-recursive-include codicefiscale *
+recursive-include src *
+recursive-include tests *
 recursive-exclude * *.pyc __pycache__ .DS_Store

README.md

@@ -134,8 +134,8 @@ pre-commit install --install-hooks
 # run tests using tox
 tox
 
-# or run tests using unittest
-python -m unittest tests.tests
+# or run tests using pytest
+pytest
 ```
 
 ## License

pyproject.toml

@@ -77,12 +77,16 @@ exclude = '''
 '''
 
 [tool.mypy]
-files = ["codicefiscale"]
+files = ["src"]
 ignore_missing_imports = true
 install_types = true
 non_interactive = true
 strict = true
 
+[tool.pytest.ini_options]
+pythonpath = "src"
+testpaths = ["tests"]
+
 [tool.ruff]
 line-length = 88
 
@@ -93,8 +97,9 @@ select = ["B", "B9", "C", "E", "F", "I", "W"]
 [tool.ruff.lint.mccabe]
 max-complexity = 10
 
-[tool.setuptools.packages.find]
-include = ["codicefiscale*"]
+[tool.setuptools]
+package-dir = {"" = "src"}
+packages = ["codicefiscale"]
 
 [tool.setuptools.dynamic.version]
 attr = "codicefiscale.metadata.__version__"

requirements-test.txt

@@ -1,4 +1,7 @@
+-e .
 coverage == 7.6.*
 mypy == 1.11.*
 pre-commit == 4.0.*
+pytest==8.3.*
+pytest-cov == 6.0.*
 tox == 4.22.*

tests/issues/__init__.py

@@ -0,0 +1,17 @@
+from codicefiscale import codicefiscale
+
+
+def test_issue_0016():
+    """
+    Decode return GIRGENTI (soppresso) instead of AGRIGENTO
+    """
+    data = codicefiscale.decode("LNNFNC80A01A089K")
+    expected_birthplace = {
+        "code": "A089",
+        "province": "AG",
+        "name": "AGRIGENTO",
+    }
+    birthplace = data["birthplace"]
+    assert birthplace["code"] == expected_birthplace["code"]
+    assert birthplace["name"].upper() == expected_birthplace["name"]
+    assert birthplace["province"] == expected_birthplace["province"]

tests/issues/test_issue_0016.py

@@ -0,0 +1,23 @@
+import pytest
+
+from codicefiscale import codicefiscale
+
+test_data = [
+    ("CCCFBA85D03Z105P", "Cecoslovacchia"),
+    ("CCCFBA85D03Z111D", "Repubblica Democratica Tedesca"),
+    ("CCCFBA85D03Z118W", "Jugoslavia"),
+    ("CCCFBA85D03Z135S", "Unione Repubbliche Socialiste Sovietiche"),
+    ("CCCFBA05D03Z157G", "Serbia e Montenegro"),
+    ("CCCFBA75D03Z201F", "Federazione dell'Arabia Meridionale"),
+    ("CCCFBA75D03Z202K", "Protettorato dell'Arabia Meridionale"),
+    ("CCCFBA85D03Z250N", "Yemen del Sud"),
+]
+
+
+@pytest.mark.parametrize("code, expected_country", test_data)
+def test_issue_0036(code, expected_country):
+    """
+    Test for decoding fiscal codes with historical country names.
+    """
+    data = codicefiscale.decode(code)
+    assert data["birthplace"]["name"] == expected_country

tests/issues/test_issue_0036.py

@@ -0,0 +1,23 @@
+from codicefiscale import codicefiscale
+
+
+def test_issue_0037():
+    """
+    Test for encoding a Codice Fiscale for a person born in Vignola (MO).
+    Ensures the correct birthplace code (L885) is used instead of L884.
+    """
+    data = {
+        "lastname": "Caccamo",
+        "firstname": "Fabio",
+        "gender": "M",
+        "birthdate": "03/04/1885",
+        "birthplace": "Vignola",
+    }
+    code = codicefiscale.encode(**data)
+    decoded_data = codicefiscale.decode(code)
+    birthplace = decoded_data["birthplace"]
+    assert birthplace is not None
+    assert isinstance(birthplace, dict)
+    assert birthplace["code"] == "L885"
+    assert birthplace["name"] == "Vignola"
+    assert birthplace["province"] == "MO"

tests/issues/test_issue_0037.py

@@ -0,0 +1,49 @@
+import datetime
+
+from codicefiscale import codicefiscale
+
+
+def test_issue_0079():
+    """
+    Test for encoding and decoding fiscal codes
+    when year of birth (excluding century) < 10 (e.g., 2004).
+    """
+    code = codicefiscale.encode(
+        lastname="Rossi",
+        firstname="Mario",
+        gender="M",
+        birthdate="29/11/2004",
+        birthplace="Torino",
+    )
+    assert code == "RSSMRA04S29L219G"
+    code_data = codicefiscale.decode("RSSMRA00S29L219C")
+    code_data.pop("omocodes")
+    expected_code_data = {
+        "code": "RSSMRA00S29L219C",
+        "gender": "M",
+        "birthdate": datetime.datetime(2000, 11, 29, 0, 0),
+        "birthplace": {
+            "active": True,
+            "code": "L219",
+            "date_created": "1889-08-12T00:00:00",
+            "date_deleted": "",
+            "name": "Torino",
+            "name_alt": "",
+            "name_alt_trans": "",
+            "name_slugs": ["torino"],
+            "name_trans": "Torino",
+            "province": "TO",
+        },
+        "raw": {
+            "code": "RSSMRA00S29L219C",
+            "lastname": "RSS",
+            "firstname": "MRA",
+            "birthdate": "00S29",
+            "birthdate_year": "00",
+            "birthdate_month": "S",
+            "birthdate_day": "29",
+            "birthplace": "L219",
+            "cin": "C",
+        },
+    }
+    assert code_data == expected_code_data

tests/issues/test_issue_0079.py

@@ -0,0 +1,24 @@
+import datetime
+
+import pytest
+
+from codicefiscale import codicefiscale
+
+test_data = [
+    ("XXXXXX39D44G133O", datetime.datetime(1939, 4, 4, 0, 0)),
+    ("XXXXXX46D11F383M", datetime.datetime(1946, 4, 11, 0, 0)),
+    ("XXXXXX50H18F383N", datetime.datetime(1950, 6, 18, 0, 0)),
+    ("XXXXXX38C71L513V", datetime.datetime(1938, 3, 31, 0, 0)),
+    ("XXXXXX43C14G133F", datetime.datetime(1943, 3, 14, 0, 0)),
+]
+
+
+@pytest.mark.parametrize("code, expected_birthdate", test_data)
+def test_issue_0113(code, expected_birthdate):
+    """
+    Test for wrong birthplace code error (missing date-range in the data-source).
+    """
+    code_data = codicefiscale.decode(code)
+    code_data.pop("omocodes")
+    code_data.pop("raw")
+    assert code_data["birthdate"] == expected_birthdate

tests/issues/test_issue_0113.py

@@ -0,0 +1,42 @@
+import datetime
+
+from codicefiscale import codicefiscale
+
+
+def test_issue_0162():
+    """
+    Test for wrong birthplace code error (missing date-range in the data-source).
+    """
+    code = "DFLNTN42T20B860H"
+    assert codicefiscale.is_valid(code)
+    code_data = codicefiscale.decode(code)
+    code_data.pop("omocodes")
+    expected_code_data = {
+        "code": "DFLNTN42T20B860H",
+        "gender": "M",
+        "birthdate": datetime.datetime(1942, 12, 20, 0, 0),
+        "birthplace": {
+            "active": False,
+            "code": "B860",
+            "date_created": "1927-01-12T00:00:00",
+            "date_deleted": "1928-06-27T00:00:00",
+            "name": "Casagiove",
+            "name_alt": "",
+            "name_alt_trans": "",
+            "name_slugs": ["casagiove"],
+            "name_trans": "Casagiove",
+            "province": "NA",
+        },
+        "raw": {
+            "code": "DFLNTN42T20B860H",
+            "lastname": "DFL",
+            "firstname": "NTN",
+            "birthdate": "42T20",
+            "birthdate_year": "42",
+            "birthdate_month": "T",
+            "birthdate_day": "20",
+            "birthplace": "B860",
+            "cin": "H",
+        },
+    }
+    assert code_data == expected_code_data

tests/issues/test_issue_0162.py

@@ -0,0 +1,47 @@
+import pytest
+
+from codicefiscale import codicefiscale
+
+
+@pytest.fixture
+def omocode_test_cases():
+    return [
+        ("CCCFBA85D03L219P", False),
+        ("CCCFBA85D03L21VE", True),
+        ("CCCFBA85D03L2MVP", True),
+        ("CCCFBA85D03LNMVE", True),
+        ("CCCFBA85D0PLNMVA", True),
+        ("CCCFBA85DLPLNMVL", True),
+        ("CCCFBA8RDLPLNMVX", True),
+        ("CCCFBAURDLPLNMVU", True),
+    ]
+
+
+@pytest.fixture
+def valid_fiscal_code_test_cases():
+    return [
+        ("CCCFBA85D03L219P", True),
+        ("CCC FBA 85 D03 L219 P", True),
+        ("CCC-FBA-85-D03-L219-P", True),
+        ("CCCFBA85D03L219PP", False),  # too long
+        ("CCCFBA85D03L219B", False),  # wrong CIN
+        ("CCCFBA85D03L219", False),  # too short
+        ("CCCFBA85D00L219", False),  # wrong birthdate day
+        ("CCCFBA85D99L219", False),  # wrong birthdate day
+    ]
+
+
+def test_is_omocode(omocode_test_cases):
+    """
+    Test the `is_omocode` function to verify if a fiscal code is an omocode.
+    """
+    for fiscal_code, expected_result in omocode_test_cases:
+        assert codicefiscale.is_omocode(fiscal_code) == expected_result
+
+
+def test_is_valid(valid_fiscal_code_test_cases):
+    """
+    Test the `is_valid` function to verify if a fiscal code is valid.
+    """
+    for fiscal_code, expected_result in valid_fiscal_code_test_cases:
+        assert codicefiscale.is_valid(fiscal_code) == expected_result