Skip to content

Commit 8d9ffb1

Browse files
cortinicofacebook-github-bot
authored andcommitted
isEnabled = true if the user provided an externalSoMapping
Summary: I'm adding an early return to `initEnableConfig` to forcefully enable SoLoader if the user provided an `externalSoMapping`. This is to prevent that users in ReactNative 0.76+ need to alter their Manifest file. Reviewed By: cipolleschi Differential Revision: D62581049 fbshipit-source-id: c7ddfaf116263eb597045a00d5f7411fad2677e0
1 parent abd12f7 commit 8d9ffb1

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

java/com/facebook/soloader/SoLoader.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -349,6 +349,13 @@ private static boolean initEnableConfig(Context context) {
349349
return true;
350350
}
351351

352+
if (SoLoader.externalSoMapping != null) {
353+
// This case is used by React Native apps that use SoMerging in OSS.
354+
// if the externalSoMapping has been provided, we don't need to check inside the Manifest
355+
// if SoLoader is enabled or not.
356+
return true;
357+
}
358+
352359
final String name = "com.facebook.soloader.enabled";
353360
Bundle metaData = null;
354361
String packageName = null;

0 commit comments

Comments
 (0)