From a816cf572c2d32b25e4a4ca5f233ef00c1611976 Mon Sep 17 00:00:00 2001
From: Will Li <minglunli@meta.com>
Date: Fri, 16 Aug 2024 16:43:27 -0700
Subject: [PATCH] Remove soft_error in http

Summary: We can still connect to daemon and proceed with some operations with server certs only, so we don't need to soft_error on this

Reviewed By: JakobDegen

Differential Revision: D60941719

fbshipit-source-id: 6440996f1eca35b6d3cbb0869f2f0542a0462e77
---
 app/buck2_http/BUCK                  | 1 -
 app/buck2_http/Cargo.toml            | 1 -
 app/buck2_http/src/client/builder.rs | 7 +------
 3 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/app/buck2_http/BUCK b/app/buck2_http/BUCK
index c99cd7d363a3..470fecb12739 100644
--- a/app/buck2_http/BUCK
+++ b/app/buck2_http/BUCK
@@ -55,7 +55,6 @@ rust_library(
         "fbsource//third-party/rust:tracing",
         "//buck2/allocative/allocative:allocative",
         "//buck2/app/buck2_certs:buck2_certs",
-        "//buck2/app/buck2_core:buck2_core",
         "//buck2/app/buck2_error:buck2_error",
         "//buck2/gazebo/dupe:dupe",
         # @oss-disable: "//common/rust/cpe:cpe", 
diff --git a/app/buck2_http/Cargo.toml b/app/buck2_http/Cargo.toml
index e479bd0c9940..ce73bfc44e41 100644
--- a/app/buck2_http/Cargo.toml
+++ b/app/buck2_http/Cargo.toml
@@ -26,7 +26,6 @@ allocative = { workspace = true }
 dupe = { workspace = true }
 
 buck2_certs = { workspace = true }
-buck2_core = { workspace = true }
 buck2_error = { workspace = true }
 
 [target.'cfg(unix)'.dependencies]
diff --git a/app/buck2_http/src/client/builder.rs b/app/buck2_http/src/client/builder.rs
index 17e2534293a2..14046093ce1c 100644
--- a/app/buck2_http/src/client/builder.rs
+++ b/app/buck2_http/src/client/builder.rs
@@ -16,7 +16,6 @@ use buck2_certs::certs::find_internal_cert;
 use buck2_certs::certs::supports_vpnless;
 use buck2_certs::certs::tls_config_with_single_cert;
 use buck2_certs::certs::tls_config_with_system_roots;
-use buck2_core::soft_error;
 use hyper::client::HttpConnector;
 use hyper::service::Service;
 use hyper::Body;
@@ -89,11 +88,7 @@ impl HttpClientBuilder {
             tracing::debug!("Using internal https client");
             builder.with_client_auth_cert(cert_path).await?;
         } else {
-            soft_error!(
-                "http_client_no_certs",
-                anyhow::anyhow!("Using default http client with no certs").into(),
-                quiet: true
-            )?;
+            tracing::debug!("Using default https client");
         }
 
         Ok(builder)