Skip to content
  • Sponsor facebook/create-react-app

  • Notifications You must be signed in to change notification settings
  • Fork 27k
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 271d5b8

Browse files
committedFeb 4, 2017
Notify rendered in Jest
1 parent d99a17c commit 271d5b8

32 files changed

+64
-96
lines changed
 

‎packages/react-scripts/fixtures/kitchensink/src/features/env/NodePath.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,7 @@ import load from 'absoluteLoad'
33

44
export default class extends Component {
55
static propTypes = {
6-
notifyRendered: PropTypes.func
7-
}
8-
9-
static defaultProps = {
10-
notifyRendered: () => {}
6+
notifyRendered: PropTypes.func.isRequired
117
}
128

139
constructor(props) {

‎packages/react-scripts/fixtures/kitchensink/src/features/env/NodePath.test.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import NodePath from './NodePath';
55
describe('NODE_PATH', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
8-
ReactDOM.render(<NodePath />, div);
8+
return new Promise(resolve => {
9+
ReactDOM.render(<NodePath notifyRendered={resolve} />, div);
10+
});
911
});
1012
});

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArrayDestructuring.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,7 @@ function load() {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func
15-
}
16-
17-
static defaultProps = {
18-
notifyRendered: () => {}
14+
notifyRendered: PropTypes.func.isRequired
1915
}
2016

2117
constructor(props) {

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArrayDestructuring.test.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import ArrayDestructuring from './ArrayDestructuring';
55
describe('array destructuring', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
8-
ReactDOM.render(<ArrayDestructuring />, div);
8+
return new Promise(resolve => {
9+
ReactDOM.render(<ArrayDestructuring notifyRendered={resolve} />, div);
10+
});
911
});
1012
});

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArraySpread.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,7 @@ function load(users) {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func
15-
}
16-
17-
static defaultProps = {
18-
notifyRendered: () => {}
14+
notifyRendered: PropTypes.func.isRequired
1915
}
2016

2117
constructor(props) {

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArraySpread.test.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import ArraySpread from './ArraySpread';
55
describe('array spread', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
8-
ReactDOM.render(<ArraySpread />, div);
8+
return new Promise(resolve => {
9+
ReactDOM.render(<ArraySpread notifyRendered={resolve} />, div);
10+
});
911
});
1012
});

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/AsyncAwait.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,7 @@ async function load() {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func
15-
}
16-
17-
static defaultProps = {
18-
notifyRendered: () => {}
14+
notifyRendered: PropTypes.func.isRequired
1915
}
2016

2117
constructor(props) {

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/AsyncAwait.test.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import AsyncAwait from './AsyncAwait';
55
describe('async/await', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
8-
ReactDOM.render(<AsyncAwait />, div);
8+
return new Promise(resolve => {
9+
ReactDOM.render(<AsyncAwait notifyRendered={resolve} />, div);
10+
});
911
});
1012
});

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/ClassProperties.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,7 @@ import React, { Component, PropTypes } from 'react'
22

33
export default class extends Component {
44
static propTypes = {
5-
notifyRendered: PropTypes.func
6-
}
7-
8-
static defaultProps = {
9-
notifyRendered: () => {}
5+
notifyRendered: PropTypes.func.isRequired
106
}
117

128
users = [

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/ClassProperties.test.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import ClassProperties from './ClassProperties';
55
describe('class properties', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
8-
ReactDOM.render(<ClassProperties />, div);
8+
return new Promise(resolve => {
9+
ReactDOM.render(<ClassProperties notifyRendered={resolve} />, div);
10+
});
911
});
1012
});

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/ComputedProperties.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,7 @@ function load(prefix) {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func
15-
}
16-
17-
static defaultProps = {
18-
notifyRendered: () => {}
14+
notifyRendered: PropTypes.func.isRequired
1915
}
2016

2117
constructor(props) {

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/ComputedProperties.test.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import ComputedProperties from './ComputedProperties';
55
describe('computed properties', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
8-
ReactDOM.render(<ComputedProperties />, div);
8+
return new Promise(resolve => {
9+
ReactDOM.render(<ComputedProperties notifyRendered={resolve} />, div);
10+
});
911
});
1012
});

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/CustomInterpolation.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,7 @@ function load() {
1616

1717
export default class extends Component {
1818
static propTypes = {
19-
notifyRendered: PropTypes.func
20-
}
21-
22-
static defaultProps = {
23-
notifyRendered: () => {}
19+
notifyRendered: PropTypes.func.isRequired
2420
}
2521

2622
constructor(props) {

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/CustomInterpolation.test.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import CustomInterpolation from './CustomInterpolation';
55
describe('custom interpolation', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
8-
ReactDOM.render(<CustomInterpolation />, div);
8+
return new Promise(resolve => {
9+
ReactDOM.render(<CustomInterpolation notifyRendered={resolve} />, div);
10+
});
911
});
1012
});

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/DefaultParameters.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,7 @@ function load(id = 0) {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func
15-
}
16-
17-
static defaultProps = {
18-
notifyRendered: () => {}
14+
notifyRendered: PropTypes.func.isRequired
1915
}
2016

2117
constructor(props) {

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/DefaultParameters.test.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import DefaultParameters from './DefaultParameters';
55
describe('default parameters', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
8-
ReactDOM.render(<DefaultParameters />, div);
8+
return new Promise(resolve => {
9+
ReactDOM.render(<DefaultParameters notifyRendered={resolve} />, div);
10+
});
911
});
1012
});

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/DestructuringAndAwait.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,7 @@ async function load() {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func
15-
}
16-
17-
static defaultProps = {
18-
notifyRendered: () => {}
14+
notifyRendered: PropTypes.func.isRequired
1915
}
2016

2117
constructor(props) {

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/DestructuringAndAwait.test.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import DestructuringAndAwait from './DestructuringAndAwait';
55
describe('destructuring and await', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
8-
ReactDOM.render(<DestructuringAndAwait />, div);
8+
return new Promise(resolve => {
9+
ReactDOM.render(<DestructuringAndAwait notifyRendered={resolve} />, div);
10+
});
911
});
1012
});

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/Generators.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,7 @@ function * load(limit) {
1010

1111
export default class extends Component {
1212
static propTypes = {
13-
notifyRendered: PropTypes.func
14-
}
15-
16-
static defaultProps = {
17-
notifyRendered: () => {}
13+
notifyRendered: PropTypes.func.isRequired
1814
}
1915

2016
constructor(props) {

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/Generators.test.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import Generators from './Generators';
55
describe('generators', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
8-
ReactDOM.render(<Generators />, div);
8+
return new Promise(resolve => {
9+
ReactDOM.render(<Generators notifyRendered={resolve} />, div);
10+
});
911
});
1012
});

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectDestructuring.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,7 @@ function load() {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func
15-
}
16-
17-
static defaultProps = {
18-
notifyRendered: () => {}
14+
notifyRendered: PropTypes.func.isRequired
1915
}
2016

2117
constructor(props) {

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectDestructuring.test.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import ObjectDestructuring from './ObjectDestructuring';
55
describe('object destructuring', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
8-
ReactDOM.render(<ObjectDestructuring />, div);
8+
return new Promise(resolve => {
9+
ReactDOM.render(<ObjectDestructuring notifyRendered={resolve} />, div);
10+
});
911
});
1012
});

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectSpread.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,7 @@ function load(baseUser) {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func
15-
}
16-
17-
static defaultProps = {
18-
notifyRendered: () => {}
14+
notifyRendered: PropTypes.func.isRequired
1915
}
2016

2117
constructor(props) {

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectSpread.test.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import ObjectSpread from './ObjectSpread';
55
describe('object spread', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
8-
ReactDOM.render(<ObjectSpread />, div);
8+
return new Promise(resolve => {
9+
ReactDOM.render(<ObjectSpread notifyRendered={resolve} />, div);
10+
});
911
});
1012
});

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/Promises.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,7 @@ function load() {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func
15-
}
16-
17-
static defaultProps = {
18-
notifyRendered: () => {}
14+
notifyRendered: PropTypes.func.isRequired
1915
}
2016

2117
constructor(props) {

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/Promises.test.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import Promises from './Promises';
55
describe('promises', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
8-
ReactDOM.render(<Promises />, div);
8+
return new Promise(resolve => {
9+
ReactDOM.render(<Promises notifyRendered={resolve} />, div);
10+
});
911
});
1012
});

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/RestAndDefault.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,7 @@ function load({ id, ...rest } = { id: 0, user: { id: 42, name: '42' } }) {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func
15-
}
16-
17-
static defaultProps = {
18-
notifyRendered: () => {}
14+
notifyRendered: PropTypes.func.isRequired
1915
}
2016

2117
constructor(props) {

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/RestAndDefault.test.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import RestAndDefault from './RestAndDefault';
55
describe('rest + default', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
8-
ReactDOM.render(<RestAndDefault />, div);
8+
return new Promise(resolve => {
9+
ReactDOM.render(<RestAndDefault notifyRendered={resolve} />, div);
10+
});
911
});
1012
});

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/RestParameters.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,7 @@ function load({ id = 0, ...rest }) {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func
15-
}
16-
17-
static defaultProps = {
18-
notifyRendered: () => {}
14+
notifyRendered: PropTypes.func.isRequired
1915
}
2016

2117
constructor(props) {

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/RestParameters.test.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import RestParameters from './RestParameters';
55
describe('rest parameters', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
8-
ReactDOM.render(<RestParameters />, div);
8+
return new Promise(resolve => {
9+
ReactDOM.render(<RestParameters notifyRendered={resolve} />, div);
10+
});
911
});
1012
});

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/TemplateInterpolation.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,7 @@ function load(name) {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func
15-
}
16-
17-
static defaultProps = {
18-
notifyRendered: () => {}
14+
notifyRendered: PropTypes.func.isRequired
1915
}
2016

2117
constructor(props) {

‎packages/react-scripts/fixtures/kitchensink/src/features/syntax/TemplateInterpolation.test.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import TemplateInterpolation from './TemplateInterpolation';
55
describe('template interpolation', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
8-
ReactDOM.render(<TemplateInterpolation />, div);
8+
return new Promise(resolve => {
9+
ReactDOM.render(<TemplateInterpolation notifyRendered={resolve} />, div);
10+
});
911
});
1012
});

0 commit comments

Comments
 (0)
Please sign in to comment.