Skip to content
  • Sponsor facebook/create-react-app

  • Notifications You must be signed in to change notification settings
  • Fork 27k
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 2ca4c84

Browse files
committedOct 29, 2017
Revert "run yarn after eject"
This reverts commit eebf1dbc19aeb6e1f66d5ec27bda2d076bea0956.
1 parent 6c7cdeb commit 2ca4c84

File tree

1 file changed

+15
-2
lines changed

1 file changed

+15
-2
lines changed
 

‎packages/react-scripts/scripts/eject.js

+15-2
Original file line numberDiff line numberDiff line change
@@ -230,8 +230,21 @@ inquirer
230230
}
231231

232232
if (fs.existsSync(paths.yarnLockFile)) {
233-
console.log(cyan('Running yarn...'));
234-
spawnSync('yarnpkg', [], { stdio: 'inherit' });
233+
// TODO: this is disabled for three reasons.
234+
//
235+
// 1. It produces garbage warnings on Windows on some systems:
236+
// https://github.com/facebookincubator/create-react-app/issues/2030
237+
//
238+
// 2. For the above reason, it breaks Windows CI:
239+
// https://github.com/facebookincubator/create-react-app/issues/2624
240+
//
241+
// 3. It is wrong anyway: re-running yarn will respect the lockfile
242+
// rather than package.json we just updated. Instead we should have
243+
// updated the lockfile. So we might as well not do it while it's broken.
244+
// https://github.com/facebookincubator/create-react-app/issues/2627
245+
//
246+
// console.log(cyan('Running yarn...'));
247+
// spawnSync('yarnpkg', [], { stdio: 'inherit' });
235248
} else {
236249
console.log(cyan('Running npm install...'));
237250
spawnSync('npm', ['install', '--loglevel', 'error'], {

0 commit comments

Comments
 (0)
Please sign in to comment.