Skip to content

Commit 474af9e

Browse files
chrisdrackettgaearon
authored andcommitted
Add support for ignoreRestSiblings in no-unused-vars (#1705)
* updating eslint to 3.16.1 * add support for ignoreRestSiblings in eslint http://eslint.org/docs/rules/no-unused-vars#ignorerestsiblings * updating eslint to 3.16.1 in `react-scripts` * updating eslint * missing `^` * missing ^ * pinning main eslint and updating readme * Pin ESLint version
1 parent 7d82964 commit 474af9e

File tree

5 files changed

+12
-11
lines changed

5 files changed

+12
-11
lines changed

package.json

+7-7
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@
1111
"test": "node packages/react-scripts/scripts/test.js --env=jsdom"
1212
},
1313
"devDependencies": {
14-
"babel-eslint": "6.1.2",
15-
"eslint": "3.5.0",
16-
"eslint-config-react-app": "0.2.1",
17-
"eslint-plugin-flowtype": "2.18.1",
18-
"eslint-plugin-import": "1.12.0",
19-
"eslint-plugin-jsx-a11y": "2.2.2",
20-
"eslint-plugin-react": "6.3.0",
14+
"babel-eslint": "7.1.0",
15+
"eslint": "3.16.1",
16+
"eslint-config-react-app": "0.5.1",
17+
"eslint-plugin-flowtype": "2.21.0",
18+
"eslint-plugin-import": "2.0.1",
19+
"eslint-plugin-jsx-a11y": "2.2.3",
20+
"eslint-plugin-react": "6.4.1",
2121
"lerna": "2.0.0-beta.38",
2222
"lerna-changelog": "^0.2.3"
2323
}

packages/eslint-config-react-app/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ If you want to use this ESLint configuration in a project not built with Create
1717
First, install this package, ESLint and the necessary plugins.
1818

1919
```sh
20-
npm install --save-dev eslint-config-react-app [email protected] eslint@3.8.1 [email protected] [email protected] [email protected] [email protected]
20+
npm install --save-dev eslint-config-react-app [email protected] eslint@3.16.1 [email protected] [email protected] [email protected] [email protected]
2121
```
2222

2323
Then create a file named `.eslintrc` with following contents in the root folder of your project:

packages/eslint-config-react-app/index.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,8 @@ module.exports = {
133133
'no-unused-vars': ['warn', {
134134
vars: 'local',
135135
varsIgnorePattern: '^_',
136-
args: 'none'
136+
args: 'none',
137+
ignoreRestSiblings: true,
137138
}],
138139
'no-use-before-define': ['warn', 'nofunc'],
139140
'no-useless-computed-key': 'warn',

packages/eslint-config-react-app/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
],
1313
"peerDependencies": {
1414
"babel-eslint": "^7.0.0",
15-
"eslint": "^3.8.1",
15+
"eslint": "^3.16.1",
1616
"eslint-plugin-flowtype": "^2.21.0",
1717
"eslint-plugin-import": "^2.0.1",
1818
"eslint-plugin-jsx-a11y": "^2.2.3",

packages/react-scripts/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
"css-loader": "0.26.1",
3838
"detect-port": "1.0.1",
3939
"dotenv": "2.0.0",
40-
"eslint": "3.8.1",
40+
"eslint": "3.16.1",
4141
"eslint-config-react-app": "^0.5.2",
4242
"eslint-loader": "1.6.0",
4343
"eslint-plugin-flowtype": "2.21.0",

0 commit comments

Comments
 (0)