Check if CI variable is set to 'false' (#2501)

varnav · Timer · commit 5b38c5439d9f · 2017-06-19T12:36:28.000-04:00
* Fix incorrect check if CI variable is set to true Originally build would fail on warnings with any value of CI environment variable. Now it will correctly check if it's true. Discussed here: #2453 * Check for "not false" instead of "not true" After discussion we decided that this will be closer to current functionality and not break anything.
diff --git a/packages/react-scripts/scripts/build.js b/packages/react-scripts/scripts/build.js
@@ -112,7 +112,7 @@ function build(previousFileSizes) {
       if (messages.errors.length) {
         return reject(new Error(messages.errors.join('\n\n')));
       }
-      if (process.env.CI && messages.warnings.length) {
+      if (process.env.CI && process.env.CI.toLowerCase() !== 'false' && messages.warnings.length) {
         console.log(
           chalk.yellow(
             '\nTreating warnings as errors because process.env.CI = true.\n' +

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ function build(previousFileSizes) {`
`112`	`112`	`if (messages.errors.length) {`
`113`	`113`	`return reject(new Error(messages.errors.join('\n\n')));`
`114`	`114`	`}`
`115`		`- if (process.env.CI && messages.warnings.length) {`
	`115`	`+ if (process.env.CI && process.env.CI.toLowerCase() !== 'false' && messages.warnings.length) {`
`116`	`116`	`console.log(`
`117`	`117`	`chalk.yellow(`
`118`	`118`	`'\nTreating warnings as errors because process.env.CI = true.\n' +`