Skip to content

Commit 6ca7a7b

Browse files
sophiebitsgaearon
authored andcommitted
Remove 'guard-for-in' lint rule (#1773)
Iterating over an object's keys using `for/in` is idiomatic and it's safe (in all modern browsers) to not check hasOwnProperty as long as the object is a plain object. Can we remove this lint rule?
1 parent f4a4e8f commit 6ca7a7b

File tree

1 file changed

+0
-1
lines changed
  • packages/eslint-config-react-app

1 file changed

+0
-1
lines changed

packages/eslint-config-react-app/index.js

-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ module.exports = {
6161
'default-case': ['warn', { commentPattern: '^no default$' }],
6262
'dot-location': ['warn', 'property'],
6363
eqeqeq: ['warn', 'allow-null'],
64-
'guard-for-in': 'warn',
6564
'new-parens': 'warn',
6665
'no-array-constructor': 'warn',
6766
'no-caller': 'warn',

0 commit comments

Comments
 (0)