Skip to content

Commit b860241

Browse files
committed
Naming changes
1 parent 8834940 commit b860241

33 files changed

+52
-52
lines changed

Diff for: packages/react-scripts/fixtures/kitchensink/src/App.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -8,23 +8,23 @@ class BuiltEmitter extends React.Component {
88
componentDidMount() {
99
const { feature } = this.props
1010
if (!Component.isPrototypeOf(feature)) {
11-
this.notifyRendered();
11+
this.handleReady();
1212
}
1313
}
1414

15-
notifyRendered() {
15+
handleReady() {
1616
document.dispatchEvent(new Event('ReactFeatureDidMount'));
1717
}
1818

1919
render() {
2020
const {
2121
props: { feature },
22-
notifyRendered
22+
handleReady
2323
} = this;
2424
return (
2525
<div>
2626
{createElement(feature, {
27-
notifyRendered
27+
onReady: handleReady
2828
})}
2929
</div>
3030
);

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/env/NodePath.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import load from 'absoluteLoad'
33

44
export default class extends Component {
55
static propTypes = {
6-
notifyRendered: PropTypes.func.isRequired
6+
onReady: PropTypes.func.isRequired
77
}
88

99
constructor(props) {
@@ -17,7 +17,7 @@ export default class extends Component {
1717
}
1818

1919
componentDidUpdate() {
20-
this.props.notifyRendered();
20+
this.props.onReady();
2121
}
2222

2323
render() {

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/env/NodePath.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ describe('NODE_PATH', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
88
return new Promise(resolve => {
9-
ReactDOM.render(<NodePath notifyRendered={resolve} />, div);
9+
ReactDOM.render(<NodePath onReady={resolve} />, div);
1010
});
1111
});
1212
});

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArrayDestructuring.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ function load() {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func.isRequired
14+
onReady: PropTypes.func.isRequired
1515
}
1616

1717
constructor(props) {
@@ -25,7 +25,7 @@ export default class extends Component {
2525
}
2626

2727
componentDidUpdate() {
28-
this.props.notifyRendered();
28+
this.props.onReady();
2929
}
3030

3131
render() {

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArrayDestructuring.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ describe('array destructuring', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
88
return new Promise(resolve => {
9-
ReactDOM.render(<ArrayDestructuring notifyRendered={resolve} />, div);
9+
ReactDOM.render(<ArrayDestructuring onReady={resolve} />, div);
1010
});
1111
});
1212
});

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArraySpread.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ function load(users) {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func.isRequired
14+
onReady: PropTypes.func.isRequired
1515
}
1616

1717
constructor(props) {
@@ -25,7 +25,7 @@ export default class extends Component {
2525
}
2626

2727
componentDidUpdate() {
28-
this.props.notifyRendered();
28+
this.props.onReady();
2929
}
3030

3131
render() {

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArraySpread.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ describe('array spread', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
88
return new Promise(resolve => {
9-
ReactDOM.render(<ArraySpread notifyRendered={resolve} />, div);
9+
ReactDOM.render(<ArraySpread onReady={resolve} />, div);
1010
});
1111
});
1212
});

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/AsyncAwait.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ async function load() {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func.isRequired
14+
onReady: PropTypes.func.isRequired
1515
}
1616

1717
constructor(props) {
@@ -25,7 +25,7 @@ export default class extends Component {
2525
}
2626

2727
componentDidUpdate() {
28-
this.props.notifyRendered();
28+
this.props.onReady();
2929
}
3030

3131
render() {

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/AsyncAwait.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ describe('async/await', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
88
return new Promise(resolve => {
9-
ReactDOM.render(<AsyncAwait notifyRendered={resolve} />, div);
9+
ReactDOM.render(<AsyncAwait onReady={resolve} />, div);
1010
});
1111
});
1212
});

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/ClassProperties.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import React, { Component, PropTypes } from 'react'
22

33
export default class extends Component {
44
static propTypes = {
5-
notifyRendered: PropTypes.func.isRequired
5+
onReady: PropTypes.func.isRequired
66
}
77

88
users = [
@@ -13,7 +13,7 @@ export default class extends Component {
1313
];
1414

1515
componentDidMount() {
16-
this.props.notifyRendered()
16+
this.props.onReady()
1717
}
1818

1919
render() {

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/ClassProperties.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ describe('class properties', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
88
return new Promise(resolve => {
9-
ReactDOM.render(<ClassProperties notifyRendered={resolve} />, div);
9+
ReactDOM.render(<ClassProperties onReady={resolve} />, div);
1010
});
1111
});
1212
});

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/ComputedProperties.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ function load(prefix) {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func.isRequired
14+
onReady: PropTypes.func.isRequired
1515
}
1616

1717
constructor(props) {
@@ -25,7 +25,7 @@ export default class extends Component {
2525
}
2626

2727
componentDidUpdate() {
28-
this.props.notifyRendered();
28+
this.props.onReady();
2929
}
3030

3131
render() {

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/ComputedProperties.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ describe('computed properties', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
88
return new Promise(resolve => {
9-
ReactDOM.render(<ComputedProperties notifyRendered={resolve} />, div);
9+
ReactDOM.render(<ComputedProperties onReady={resolve} />, div);
1010
});
1111
});
1212
});

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/CustomInterpolation.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ function load() {
1616

1717
export default class extends Component {
1818
static propTypes = {
19-
notifyRendered: PropTypes.func.isRequired
19+
onReady: PropTypes.func.isRequired
2020
}
2121

2222
constructor(props) {
@@ -30,7 +30,7 @@ export default class extends Component {
3030
}
3131

3232
componentDidUpdate() {
33-
this.props.notifyRendered();
33+
this.props.onReady();
3434
}
3535

3636
render() {

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/CustomInterpolation.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ describe('custom interpolation', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
88
return new Promise(resolve => {
9-
ReactDOM.render(<CustomInterpolation notifyRendered={resolve} />, div);
9+
ReactDOM.render(<CustomInterpolation onReady={resolve} />, div);
1010
});
1111
});
1212
});

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/DefaultParameters.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ function load(id = 0) {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func.isRequired
14+
onReady: PropTypes.func.isRequired
1515
}
1616

1717
constructor(props) {
@@ -25,7 +25,7 @@ export default class extends Component {
2525
}
2626

2727
componentDidUpdate() {
28-
this.props.notifyRendered();
28+
this.props.onReady();
2929
}
3030

3131
render() {

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/DefaultParameters.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ describe('default parameters', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
88
return new Promise(resolve => {
9-
ReactDOM.render(<DefaultParameters notifyRendered={resolve} />, div);
9+
ReactDOM.render(<DefaultParameters onReady={resolve} />, div);
1010
});
1111
});
1212
});

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/DestructuringAndAwait.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ async function load() {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func.isRequired
14+
onReady: PropTypes.func.isRequired
1515
}
1616

1717
constructor(props) {
@@ -25,7 +25,7 @@ export default class extends Component {
2525
}
2626

2727
componentDidUpdate() {
28-
this.props.notifyRendered();
28+
this.props.onReady();
2929
}
3030

3131
render() {

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/DestructuringAndAwait.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ describe('destructuring and await', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
88
return new Promise(resolve => {
9-
ReactDOM.render(<DestructuringAndAwait notifyRendered={resolve} />, div);
9+
ReactDOM.render(<DestructuringAndAwait onReady={resolve} />, div);
1010
});
1111
});
1212
});

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/Generators.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ function * load(limit) {
1010

1111
export default class extends Component {
1212
static propTypes = {
13-
notifyRendered: PropTypes.func.isRequired
13+
onReady: PropTypes.func.isRequired
1414
}
1515

1616
constructor(props) {
@@ -27,7 +27,7 @@ export default class extends Component {
2727
}
2828

2929
componentDidUpdate() {
30-
this.props.notifyRendered();
30+
this.props.onReady();
3131
}
3232

3333
render() {

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/Generators.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ describe('generators', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
88
return new Promise(resolve => {
9-
ReactDOM.render(<Generators notifyRendered={resolve} />, div);
9+
ReactDOM.render(<Generators onReady={resolve} />, div);
1010
});
1111
});
1212
});

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectDestructuring.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ function load() {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func.isRequired
14+
onReady: PropTypes.func.isRequired
1515
}
1616

1717
constructor(props) {
@@ -25,7 +25,7 @@ export default class extends Component {
2525
}
2626

2727
componentDidUpdate() {
28-
this.props.notifyRendered();
28+
this.props.onReady();
2929
}
3030

3131
render() {

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectDestructuring.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ describe('object destructuring', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
88
return new Promise(resolve => {
9-
ReactDOM.render(<ObjectDestructuring notifyRendered={resolve} />, div);
9+
ReactDOM.render(<ObjectDestructuring onReady={resolve} />, div);
1010
});
1111
});
1212
});

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectSpread.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ function load(baseUser) {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func.isRequired
14+
onReady: PropTypes.func.isRequired
1515
}
1616

1717
constructor(props) {
@@ -25,7 +25,7 @@ export default class extends Component {
2525
}
2626

2727
componentDidUpdate() {
28-
this.props.notifyRendered();
28+
this.props.onReady();
2929
}
3030

3131
render() {

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/ObjectSpread.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ describe('object spread', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
88
return new Promise(resolve => {
9-
ReactDOM.render(<ObjectSpread notifyRendered={resolve} />, div);
9+
ReactDOM.render(<ObjectSpread onReady={resolve} />, div);
1010
});
1111
});
1212
});

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/Promises.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ function load() {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func.isRequired
14+
onReady: PropTypes.func.isRequired
1515
}
1616

1717
constructor(props) {
@@ -26,7 +26,7 @@ export default class extends Component {
2626
}
2727

2828
componentDidUpdate() {
29-
this.props.notifyRendered();
29+
this.props.onReady();
3030
}
3131

3232
render() {

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/Promises.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ describe('promises', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
88
return new Promise(resolve => {
9-
ReactDOM.render(<Promises notifyRendered={resolve} />, div);
9+
ReactDOM.render(<Promises onReady={resolve} />, div);
1010
});
1111
});
1212
});

Diff for: packages/react-scripts/fixtures/kitchensink/src/features/syntax/RestAndDefault.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ function load({ id, ...rest } = { id: 0, user: { id: 42, name: '42' } }) {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func.isRequired
14+
onReady: PropTypes.func.isRequired
1515
}
1616

1717
constructor(props) {
@@ -25,7 +25,7 @@ export default class extends Component {
2525
}
2626

2727
componentDidUpdate() {
28-
this.props.notifyRendered();
28+
this.props.onReady();
2929
}
3030

3131
render() {

0 commit comments

Comments
 (0)