Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimal Node version to 4.7.0? #1637

Closed
gaearon opened this issue Feb 24, 2017 · 6 comments
Closed

Bump minimal Node version to 4.7.0? #1637

gaearon opened this issue Feb 24, 2017 · 6 comments
Labels
contributions: claimed
Milestone
1.0.0

Comments

@gaearon
Copy link
Contributor

gaearon commented Feb 24, 2017

Noticed this on master:

[email protected]: The engine "node" is incompatible with this module. Expected version ">=4.3.0 < 5.0.0 || >= 5.10".
@gaearon gaearon added this to the 0.10.0 milestone Feb 24, 2017
@gaearon gaearon changed the title Bump minimal Node version to 4.3.0? Bump minimal Node version to 4.7.0? Feb 24, 2017
@gaearon
Copy link
Contributor Author

gaearon commented Feb 24, 2017

And even this:

[email protected]: The engine "node" is incompatible with this module. Expected version ">=4.7".

@Timer
Copy link
Contributor

Timer commented Feb 24, 2017

I see no harm in this.

@gaearon
Copy link
Contributor Author

gaearon commented Feb 24, 2017

Yea, just saying we need to update the docs and the CRA script once the minimal required version actually changes.

@ianschmitz
Copy link
Contributor

Mind if I hop on this?

@Timer
Copy link
Contributor

Timer commented Mar 27, 2017

Sure, go ahead!

@ianschmitz ianschmitz mentioned this issue Mar 27, 2017
Merged
@gaearon
Copy link
Contributor Author

gaearon commented May 14, 2017

Done in #1897.

@gaearon gaearon closed this as completed May 14, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
contributions: claimed
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@Timer @gaearon @ianschmitz