Skip to content

after npm run reject, package all in dependencies? #4315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
didiaodihaizi opened this issue Apr 17, 2018 · 2 comments
Closed

after npm run reject, package all in dependencies? #4315

didiaodihaizi opened this issue Apr 17, 2018 · 2 comments

Comments

@didiaodihaizi
Copy link

A new create-react-app project,then i npm run reject, i found all package all in dependencies,like babel,eslint,webpack, should i move them to devdependencies?

tim 20180417092615
@ghost
Copy link

ghost commented Apr 17, 2018 •
edited by ghost
Loading

This should help: #4310

You can move the modules back to devDependencies if you want except for react, react-dom, and polyfills used by CRA

@Timer
Copy link
Contributor

Timer commented Apr 17, 2018

You can do as you wish. We suggest leaving them in dependencies.

@Timer Timer closed this as completed Apr 17, 2018
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Timer @didiaodihaizi