Fix deprecations & support current PHP versions (#624)

Summary: Pull Request resolved: #624

Reviewed By: satwikareddy3

Differential Revision: D69256661

Pulled By: stcheng

fbshipit-source-id: c8c8420cc52d3954267f8bc10e0e284d99baa77d

Author: mpesari

.github/workflows/ci.yml

@@ -7,7 +7,7 @@ jobs:
     strategy:
       matrix:
         operating-system: [ubuntu-latest]
-        php-versions: ['8.0', '8.1', '8.2']
+        php-versions: ['8.0', '8.1', '8.2', '8.3', '8.4']
     name: PHP ${{ matrix.php-versions }} Test on ${{ matrix.operating-system }}
     steps:
     - name: Checkout

src/FacebookAds/ApiRequest.php

@@ -36,7 +36,7 @@ public function __construct(
     $return_prototype = null,
     $api_type = null,
     $accepted_fields = array(),
-    TypeChecker $param_checker = null,
+    ?TypeChecker $param_checker = null,
     $allow_file_upload = false,
     $use_graph_video_endpoint = false) {
     $this->fields = [];

src/FacebookAds/Cursor.php

@@ -63,7 +63,7 @@ class Cursor implements \Iterator, \Countable, \ArrayAccess {
   public function __construct(
     ResponseInterface $response,
     AbstractObject $object_prototype,
-    Api $api = null) {
+    ?Api $api = null) {
     $this->response = $response;
     $this->objectPrototype = $object_prototype;
     $this->api = $api !== null ? $api : Api::instance();

src/FacebookAds/Http/Adapter/CurlAdapter.php

@@ -49,7 +49,7 @@ class CurlAdapter extends AbstractAdapter {
    * @param Client $client
    * @param CurlInterface $curl
    */
-  public function __construct(Client $client, CurlInterface $curl = null) {
+  public function __construct(Client $client, ?CurlInterface $curl = null) {
     parent::__construct($client);
     $this->curl = $curl ?: AbstractCurl::createOptimalVersion();
     $this->curl->init();
@@ -90,7 +90,7 @@ public function setOpts(\ArrayObject $opts) {
    * @return int
    */
   protected function getheaderSize() {
-    return $this->getCurl()->getInfo(CURLINFO_HEADER_SIZE);
+    return $this->getCurl()->getInfo(CURLINFO_HEADER_SIZE) ?? 0;
   }
 
   /**

src/FacebookAds/Http/Exception/RequestException.php

@@ -87,7 +87,7 @@ public function __construct(ResponseInterface $response) {
     $this->response = $response;
     $error_data = static::getErrorData($response);
 
-    parent::__construct($error_data['message'], $error_data['code'] ?? 0);
+    parent::__construct($error_data['message'] ?? '', $error_data['code'] ?? 0);
 
     $this->errorSubcode = $error_data['error_subcode'];
     $this->errorUserTitle = $error_data['error_user_title'];

src/FacebookAds/Object/AbstractCrudObject.php

@@ -40,7 +40,7 @@ class AbstractCrudObject extends AbstractObject {
    * @param string $parent_id Optional, needed for creating new objects.
    * @param Api $api The Api instance this object should use to make calls
    */
-  public function __construct($id = null, $parent_id = null, Api $api = null) {
+  public function __construct($id = null, $parent_id = null, ?Api $api = null) {
     parent::__construct();
 
     // check that $id is an integer or a string integer or a string of
@@ -113,7 +113,7 @@ protected function getEndpoint() {
    * @return Api
    * @throws \InvalidArgumentException
    */
-  protected static function assureApi(Api $instance = null) {
+  protected static function assureApi(?Api $instance = null) {
     $instance = $instance ?: Api::instance();
     if (!$instance) {
       throw new \InvalidArgumentException(
@@ -460,7 +460,7 @@ protected function createAsyncJob(
    * @param Api $api Api Object to use
    * @return bool Returns true on success
    */
-  public static function deleteIds(array $ids, Api $api = null) {
+  public static function deleteIds(array $ids, ?Api $api = null) {
     $batch = array();
     foreach ($ids as $id) {
       $request = array(
@@ -495,7 +495,7 @@ public static function readIds(
     array $ids,
     array $fields = array(),
     array $params = array(),
-    Api $api = null) {
+    ?Api $api = null) {
     if (empty($fields)) {
       $fields = static::getDefaultReadFields();
     }

src/FacebookAds/Object/AdImage.php

@@ -81,7 +81,7 @@ public function getSelf(array $fields = array(), array $params = array(), $pendi
    * @return array
    */
   public static function createFromZip(
-    $file_path, $account_id, array $params = array(), Api $api = null) {
+    $file_path, $account_id, array $params = array(), ?Api $api = null) {
 
     $image = new AdImage(null, $account_id, $api);
     $image->{AdImageFields::FILENAME} = $file_path;

src/FacebookAds/Object/BusinessDataAPI/Content.php

@@ -35,7 +35,7 @@ class Content {
    * Constructor
    * @param mixed[] $data Associated array of property value initializing the model
    */
-  public function __construct(array $data = null) {
+  public function __construct(?array $data = null) {
     $this->container['product_id'] = isset($data['product_id']) ? $data['product_id'] : null;;
     $this->container['quantity'] = isset($data['quantity']) ? $data['quantity'] : null;
     $this->container['price'] = isset($data['price']) ? $data['price'] : null;

src/FacebookAds/Object/BusinessDataAPI/CustomData.php

@@ -36,7 +36,7 @@ class CustomData {
    * Constructor
    * @param mixed[] $data Associated array of property value initializing the model
    */
-  public function __construct(array $data = null) {
+  public function __construct(?array $data = null) {
     $this->container['value'] = isset($data['value']) ? $data['value'] : null;
     $this->container['currency'] = isset($data['currency']) ? $data['currency'] : null;
     $this->container['contents'] = isset($data['contents']) ? $data['contents'] : null;

src/FacebookAds/Object/BusinessDataAPI/Event.php

@@ -36,7 +36,7 @@ class Event {
    * Constructor
    * @param mixed[] $data Associated array of property value initalizing the model
    */
-  public function __construct(array $data = null) {
+  public function __construct(?array $data = null) {
     $this->container['event_name'] = isset($data['event_name']) ? $data['event_name'] : null;
     $this->container['event_time'] = isset($data['event_time']) ? $data['event_time'] : null;
     $this->container['event_id'] = isset($data['event_id']) ? $data['event_id'] : null;