From 212bf7e458b57482b2dfe9c3a668f2696a86deae Mon Sep 17 00:00:00 2001
From: Richard Barnes <rbarnes@meta.com>
Date: Sun, 18 Feb 2024 10:31:37 -0800
Subject: [PATCH] Remove semicolon(s) from 3 files inc
 fboss/lib/AlertLogger.cpp

Summary:
X-link: https://github.com/facebookresearch/fbpcf/pull/532

`-Wextra-semi` or `-Wextra-semi-stmt` found an extra semi

If the code compiles, this is safe to land.

Reviewed By: palmje, dmm-fb

Differential Revision: D53776137

fbshipit-source-id: cc37bcdc7150e3f91e0e26dbf37eae671c583179
---
 fboss/lib/AlertLogger.cpp   | 38 ++++++++++++++++++-------------------
 fboss/lib/HwWriteBehavior.h |  2 +-
 2 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/fboss/lib/AlertLogger.cpp b/fboss/lib/AlertLogger.cpp
index b9ba768b5912f..0e259b0bf8912 100644
--- a/fboss/lib/AlertLogger.cpp
+++ b/fboss/lib/AlertLogger.cpp
@@ -32,22 +32,22 @@ constexpr auto kFbossLinkSnapshotAlert("LINK_SNAPSHOT");
 
 // Alert tag by type
 AlertTag::AlertTag(std::string prefix, std::string sub_type)
-    : prefix_(std::move(prefix)), sub_type_(std::move(sub_type)){};
+    : prefix_(std::move(prefix)), sub_type_(std::move(sub_type)) {}
 
-MiscAlert::MiscAlert() : AlertTag(kFbossAlertPrefix, kFbossMiscAlert){};
-AsicAlert::AsicAlert() : AlertTag(kFbossAlertPrefix, kFbossAsicAlert){};
+MiscAlert::MiscAlert() : AlertTag(kFbossAlertPrefix, kFbossMiscAlert) {}
+AsicAlert::AsicAlert() : AlertTag(kFbossAlertPrefix, kFbossAsicAlert) {}
 ServiceAlert::ServiceAlert()
-    : AlertTag(kFbossAlertPrefix, kFbossServiceAlert){};
+    : AlertTag(kFbossAlertPrefix, kFbossServiceAlert) {}
 PlatformAlert::PlatformAlert()
-    : AlertTag(kFbossAlertPrefix, kFbossPlatformAlert){};
-BmcAlert::BmcAlert() : AlertTag(kFbossAlertPrefix, kFbossBmcAlert){};
-KernelAlert::KernelAlert() : AlertTag(kFbossAlertPrefix, kFbossKernelAlert){};
-PortAlert::PortAlert() : AlertTag(kFbossAlertPrefix, kFbossPortAlert){};
-RouteAlert::RouteAlert() : AlertTag(kFbossAlertPrefix, kFbossRouteAlert){};
-BGPAlert::BGPAlert() : AlertTag(kBgpAlertPrefix){};
-MKAAlert::MKAAlert() : AlertTag(kMkaAlertPrefix){};
+    : AlertTag(kFbossAlertPrefix, kFbossPlatformAlert) {}
+BmcAlert::BmcAlert() : AlertTag(kFbossAlertPrefix, kFbossBmcAlert) {}
+KernelAlert::KernelAlert() : AlertTag(kFbossAlertPrefix, kFbossKernelAlert) {}
+PortAlert::PortAlert() : AlertTag(kFbossAlertPrefix, kFbossPortAlert) {}
+RouteAlert::RouteAlert() : AlertTag(kFbossAlertPrefix, kFbossRouteAlert) {}
+BGPAlert::BGPAlert() : AlertTag(kBgpAlertPrefix) {}
+MKAAlert::MKAAlert() : AlertTag(kMkaAlertPrefix) {}
 LinkSnapshotAlert::LinkSnapshotAlert()
-    : AlertTag(kLinkSnapshotAlertPrefix, kFbossLinkSnapshotAlert){};
+    : AlertTag(kLinkSnapshotAlertPrefix, kFbossLinkSnapshotAlert) {}
 
 // Alert param types
 constexpr auto kFbossPort("port");
@@ -59,14 +59,14 @@ constexpr auto kFbossLinkSnapshot("linkSnapshot");
 
 // Alert parameter types
 AlertParam::AlertParam(std::string type, std::string value)
-    : type_(std::move(type)), value_(std::move(value)){};
+    : type_(std::move(type)), value_(std::move(value)) {}
 
-PortParam::PortParam(std::string value) : AlertParam(kFbossPort, value){};
-VlanParam::VlanParam(std::string value) : AlertParam(kFbossVlan, value){};
-Ipv4Param::Ipv4Param(std::string value) : AlertParam(kFbossIpv4Addr, value){};
-Ipv6Param::Ipv6Param(std::string value) : AlertParam(kFbossIpv6Addr, value){};
-MacParam::MacParam(std::string value) : AlertParam(kFbossMacAddr, value){};
+PortParam::PortParam(std::string value) : AlertParam(kFbossPort, value) {}
+VlanParam::VlanParam(std::string value) : AlertParam(kFbossVlan, value) {}
+Ipv4Param::Ipv4Param(std::string value) : AlertParam(kFbossIpv4Addr, value) {}
+Ipv6Param::Ipv6Param(std::string value) : AlertParam(kFbossIpv6Addr, value) {}
+MacParam::MacParam(std::string value) : AlertParam(kFbossMacAddr, value) {}
 LinkSnapshotParam::LinkSnapshotParam(std::string value)
-    : AlertParam(kFbossLinkSnapshot, value){};
+    : AlertParam(kFbossLinkSnapshot, value) {}
 
 } // namespace facebook::fboss
diff --git a/fboss/lib/HwWriteBehavior.h b/fboss/lib/HwWriteBehavior.h
index de2ed0565736d..be78ff30e25fc 100644
--- a/fboss/lib/HwWriteBehavior.h
+++ b/fboss/lib/HwWriteBehavior.h
@@ -25,4 +25,4 @@ class HwWriteBehaviorRAII {
  private:
   HwWriteBehavior prevBehavior_;
 };
-}; // namespace facebook::fboss
+} // namespace facebook::fboss