Skip to content

Commit

Permalink
Remove unused SMB_CPLD from platform_manager.json sensors (#339)
Browse files Browse the repository at this point in the history
Summary:
### Description:
1) Remove the following configuration from platform_manager.json:
  `/run/devmap/sensors/SMB_CPLD`: `/SMB_SLOT@0/[SMB_CPLD]`

### Motivation:
1) The 0xB8 register in SMB_CPLD has no effect because SP4 lacks a TEMP_CLK signal.
   So the max temperature defined in register 0xB8 cannot be detected.
2) As a result, `temp1_input` in the SMB_CPLD driver has been removed, so this config needs to be updated accordingly.
3) This sensor was already removed from `sensor_service.json` earlier, so no changes are needed for the sensor_service config.

Pull Request resolved: #339

Test Plan:
1) Ran `platform_manager` with the updated config.
2) Confirmed that SMB_CPLD no longer exists in `/run/devmap/sensors/` by checking the directory

Reviewed By: somasun

Differential Revision: D69924901

Pulled By: kimdo8736

fbshipit-source-id: 0a73e388c26fc51e3766779e29ca9f6144a25086
  • Loading branch information
brandonchuang authored and facebook-github-bot committed Feb 20, 2025
1 parent 32e0d56 commit 755c854
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion fboss/platform/configs/minipack3n/platform_manager.json
Original file line number Diff line number Diff line change
Expand Up @@ -3196,7 +3196,6 @@
"/run/devmap/sensors/PDB_R_TSENSOR": "/PDBRIGHT_SLOT@0/[PDB_R_TSENSOR]",
"/run/devmap/sensors/SMB_VRM1": "/SMB_SLOT@0/[SMB_VRM1]",
"/run/devmap/sensors/SMB_VOLTAGE_MONITOR1": "/SMB_SLOT@0/[SMB_VOLTAGE_MONITOR1]",
"/run/devmap/sensors/SMB_CPLD": "/SMB_SLOT@0/[SMB_CPLD]",
"/run/devmap/sensors/SMB_VRM2": "/SMB_SLOT@0/[SMB_VRM2]",
"/run/devmap/sensors/SMB_VRM3": "/SMB_SLOT@0/[SMB_VRM3]",
"/run/devmap/sensors/SMB_VRM4": "/SMB_SLOT@0/[SMB_VRM4]",
Expand Down

0 comments on commit 755c854

Please sign in to comment.