-
Notifications
You must be signed in to change notification settings - Fork 309
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add portVoqConfigName to switch_config.thrift
Summary: Currently on J3 platforms, all ports including cpu/rcy ports are using "defaultVoqConfig" which has 4 queues and only meant for NIF ports. Cpu/rcy ports and future queuing model in 2-stage ramon could have different voq settings for different ports. So, similar to "portQueueConfigName", we need to define the corresponding voq config in "portQueueConfigs" and apply it to ports if different from "defaultVoqConfig". Note: I tried adding another dedicated map collection "portVoqConfigs" for voqs in D61608453, but got build error from generated fsdb_model.h, see P1539329134. peygar helped looking into it, but looks like a limitation not easy to fix... Here is his comments: The type of map<PortVoqConfigName, list<PortQueue>> portVoqConfigs Is exactly the same as map<PortQueueConfigName, list<PortQueue>> portQueueConfigs because PortQueueConfigName == PortVoqConfigName == std::string. But our codegen is not smart enough to realize than and generates two different thriftpath classes which end up colliding. Reviewed By: peygar, nivinl Differential Revision: D61664711 Privacy Context Container: L1125642 fbshipit-source-id: 7db360a60d718b58611df56bb2454d3b8a9536e7
- Loading branch information
1 parent
e39e29b
commit 8268dd5
Showing
2 changed files
with
9 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters