Skip to content

Commit d21b7af

Browse files
Brett Lavallafacebook-github-bot
Brett Lavalla
authored andcommitted
Fix test failure caused by flags switch from int to long
Summary: D51734814 switched Litho's NodeInfo flags from an Int to a Long, since they exceeded 32 flags, but this test was still expecting them to be ints. Differential Revision: D51968513 fbshipit-source-id: fa01ea25ef0c7139685b57483111a927cb6cbe97
1 parent f34db76 commit d21b7af

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

litho-it/src/test/java/com/facebook/litho/NodeInfoTest.kt

+6-6
Original file line numberDiff line numberDiff line change
@@ -366,20 +366,20 @@ class NodeInfoTest {
366366
}
367367

368368
private fun isFlagSet(nodeInfo: NodeInfo?, flagName: String): Boolean {
369-
val flagPosition = Whitebox.getInternalState<Int>(NodeInfo::class.java, flagName)
370-
val flags = Whitebox.getInternalState<Int>(nodeInfo, "mPrivateFlags")
371-
return flags and flagPosition != 0
369+
val flagPosition = Whitebox.getInternalState<Long>(NodeInfo::class.java, flagName)
370+
val flags = Whitebox.getInternalState<Long>(nodeInfo, "mPrivateFlags")
371+
return flags and flagPosition != 0L
372372
}
373373

374374
private fun clearFlag(nodeInfo: NodeInfo?, flagName: String) {
375-
val flagPosition = Whitebox.getInternalState<Int>(NodeInfo::class.java, flagName)
376-
var flags = Whitebox.getInternalState<Int>(nodeInfo, "mPrivateFlags")
375+
val flagPosition = Whitebox.getInternalState<Long>(NodeInfo::class.java, flagName)
376+
var flags = Whitebox.getInternalState<Long>(nodeInfo, "mPrivateFlags")
377377
flags = flags and flagPosition.inv()
378378
Whitebox.setInternalState(nodeInfo, "mPrivateFlags", flags)
379379
}
380380

381381
private fun assertEmptyFlags(nodeInfo: NodeInfo?) {
382-
assertThat(Whitebox.getInternalState<Any>(nodeInfo, "mPrivateFlags") as Int == 0).isTrue
382+
assertThat(Whitebox.getInternalState<Any>(nodeInfo, "mPrivateFlags") as Long == 0L).isTrue
383383
}
384384
}
385385
}

0 commit comments

Comments
 (0)