Add ability to log non fatals regarding improper mount release

Summary:
I'm adding a new non-fatal with the goal of identifying improper mount content releases into the Pool on IG. Hopefully this will be able to signal some situations that we are not being able to repro and then fix them, so as to avoid leaks.

This will be only enabled for a small percentage of users, to avoid noise.

Differential Revision: D60234842

fbshipit-source-id: 5d63809ede626b7cef49fccfb4f353b4178cee6f

Author: Fabio Carballo

litho-rendercore/src/main/java/com/facebook/rendercore/MountItemPoolsReleaseValidator.kt

@@ -34,6 +34,7 @@ import java.lang.reflect.Field
 internal class MountItemPoolsReleaseValidator(
     private val failOnDetection: Boolean = false,
     private val excludedPatterns: Set<Regex> = emptySet(),
+    private val onInvalidRelease: ((exception: InvalidReleaseToMountPoolException) -> Unit)? = null,
     /**
      * These are fields the client can add for custom fields they want to inspect. If you have a
      * custom view you can define a specific extraction that verifies if a listener was properly
@@ -119,6 +120,8 @@ internal class MountItemPoolsReleaseValidator(
         append("\n")
       }
 
+      onInvalidRelease?.invoke(InvalidReleaseToMountPoolException(result))
+
       if (failOnDetection) {
         assert(false) { result }
       } else {
@@ -170,3 +173,9 @@ internal class MountItemPoolsReleaseValidator(
 }
 
 private const val TAG = "MountReleaseValidator"
+
+/**
+ * This exception is thrown when a view is released to the pool but it has a listener or any other
+ * view property that was not cleaned up.
+ */
+class InvalidReleaseToMountPoolException(message: String) : RuntimeException(message)

litho-rendercore/src/main/java/com/facebook/rendercore/MountItemsPool.kt

@@ -376,10 +376,14 @@ object MountItemsPool {
    */
   fun enableItemsReleaseValidation(
       failOnDetection: Boolean,
-      excludedPatterns: Set<Regex> = emptySet()
+      excludedPatterns: Set<Regex> = emptySet(),
+      onInvalidRelease: (exception: InvalidReleaseToMountPoolException) -> Unit
   ) {
     mountItemPoolsReleaseValidator =
-        MountItemPoolsReleaseValidator(failOnDetection, excludedPatterns)
+        MountItemPoolsReleaseValidator(
+            failOnDetection = failOnDetection,
+            excludedPatterns = excludedPatterns,
+            onInvalidRelease = onInvalidRelease)
   }
 
   /** Content item pools that RenderCore uses to recycle content (such as Views) */