Update Alert types to use .js.flow as the common interface file (#49116)

Summary:
Pull Request resolved: #49116

Changelog: [Internal]

Differential Revision: D69044714

Author: j-piasecki

packages/react-native/Libraries/Alert/Alert.js

@@ -9,13 +9,11 @@
  */
 
 import type {DialogOptions} from '../NativeModules/specs/NativeDialogManagerAndroid';
-import type {AlertOptions, AlertType, Buttons} from './Alert.flow';
+import type {AlertOptions, AlertType, Buttons} from './AlertTypes.flow';
 
 import Platform from '../Utilities/Platform';
 import RCTAlertManager from './RCTAlertManager';
 
-export type * from './Alert.flow';
-
 class Alert {
   static alert(
     title: ?string,

packages/react-native/Libraries/Alert/Alert.js.flow

@@ -0,0 +1,39 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @format
+ * @flow
+ */
+
+import type {AlertOptions, AlertType, Buttons} from './AlertTypes.flow';
+
+export type * from './AlertTypes.flow';
+
+/**
+ * Launches an alert dialog with the specified title and message.
+ *
+ * See https://reactnative.dev/docs/alert
+ */
+declare class Alert {
+  static alert(
+    title: ?string,
+    message?: ?string,
+    buttons?: Buttons,
+    options?: AlertOptions,
+  ): void;
+
+  static prompt(
+    title: ?string,
+    message?: ?string,
+    callbackOrButtons?: ?(((text: string) => void) | Buttons),
+    type?: ?AlertType,
+    defaultValue?: string,
+    keyboardType?: string,
+    options?: AlertOptions,
+  ): void;
+}
+
+export default Alert;

packages/react-native/Libraries/Alert/Alert.flow.js renamed to packages/react-native/Libraries/Alert/AlertTypes.flow.js

@@ -34,29 +34,3 @@ export type AlertOptions = {
   onDismiss?: ?() => void,
   ...
 };
-
-/**
- * Launches an alert dialog with the specified title and message.
- *
- * See https://reactnative.dev/docs/alert
- */
-declare class Alert {
-  static alert(
-    title: ?string,
-    message?: ?string,
-    buttons?: Buttons,
-    options?: AlertOptions,
-  ): void;
-
-  static prompt(
-    title: ?string,
-    message?: ?string,
-    callbackOrButtons?: ?(((text: string) => void) | Buttons),
-    type?: ?AlertType,
-    defaultValue?: string,
-    keyboardType?: string,
-    options?: AlertOptions,
-  ): void;
-}
-
-export default Alert;

packages/react-native/Libraries/Alert/RCTAlertManager.flow.js

@@ -53,28 +53,8 @@ declare export default typeof NativeActionSheetManager;
 "
 `;
 
-exports[`public API should not change unintentionally Libraries/Alert/Alert.flow.js 1`] = `
-"export type AlertType =
-  | \\"default\\"
-  | \\"plain-text\\"
-  | \\"secure-text\\"
-  | \\"login-password\\";
-export type AlertButtonStyle = \\"default\\" | \\"cancel\\" | \\"destructive\\";
-export type AlertButton = {
-  text?: string,
-  onPress?: ?((value?: string) => any) | ?Function,
-  isPreferred?: boolean,
-  style?: AlertButtonStyle,
-  ...
-};
-export type Buttons = Array<AlertButton>;
-export type AlertOptions = {
-  cancelable?: ?boolean,
-  userInterfaceStyle?: \\"unspecified\\" | \\"light\\" | \\"dark\\",
-  onDismiss?: ?() => void,
-  ...
-};
-declare class Alert {
+exports[`public API should not change unintentionally Libraries/Alert/Alert.js 1`] = `
+"declare class Alert {
   static alert(
     title: ?string,
     message?: ?string,
@@ -95,8 +75,8 @@ declare export default typeof Alert;
 "
 `;
 
-exports[`public API should not change unintentionally Libraries/Alert/Alert.js 1`] = `
-"export type * from \\"./Alert.flow\\";
+exports[`public API should not change unintentionally Libraries/Alert/Alert.js.flow 1`] = `
+"export type * from \\"./AlertTypes.flow\\";
 declare class Alert {
   static alert(
     title: ?string,
@@ -118,20 +98,33 @@ declare export default typeof Alert;
 "
 `;
 
-exports[`public API should not change unintentionally Libraries/Alert/NativeAlertManager.js 1`] = `
-"export * from \\"../../src/private/specs_DEPRECATED/modules/NativeAlertManager\\";
-declare export default typeof NativeAlertManager;
+exports[`public API should not change unintentionally Libraries/Alert/AlertTypes.flow.js 1`] = `
+"export type AlertType =
+  | \\"default\\"
+  | \\"plain-text\\"
+  | \\"secure-text\\"
+  | \\"login-password\\";
+export type AlertButtonStyle = \\"default\\" | \\"cancel\\" | \\"destructive\\";
+export type AlertButton = {
+  text?: string,
+  onPress?: ?((value?: string) => any) | ?Function,
+  isPreferred?: boolean,
+  style?: AlertButtonStyle,
+  ...
+};
+export type Buttons = Array<AlertButton>;
+export type AlertOptions = {
+  cancelable?: ?boolean,
+  userInterfaceStyle?: \\"unspecified\\" | \\"light\\" | \\"dark\\",
+  onDismiss?: ?() => void,
+  ...
+};
 "
 `;
 
-exports[`public API should not change unintentionally Libraries/Alert/RCTAlertManager.flow.js 1`] = `
-"declare const RCTAlertManager: {
-  alertWithArgs(
-    args: Args,
-    callback: (id: number, value: string) => void
-  ): void,
-};
-declare export default typeof RCTAlertManager;
+exports[`public API should not change unintentionally Libraries/Alert/NativeAlertManager.js 1`] = `
+"export * from \\"../../src/private/specs_DEPRECATED/modules/NativeAlertManager\\";
+declare export default typeof NativeAlertManager;
 "
 `;
 

packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap

@@ -21,11 +21,11 @@ const path = require('path');
 const {parseArgs} = require('util');
 
 const TYPES_DIR = 'types_generated';
-const IGNORE_PATTERN = '**/__{tests,mocks,fixtures}__/**';
+const IGNORE_PATTERN = '**/__{tests,mocks,fixtures,flowtests}__/**';
 
 const SOURCE_PATTERNS = [
   // Start with Animated only
-  'react-native/Libraries/Alert/**/*.js',
+  'react-native/Libraries/Alert/**/*.{js,flow}',
   'react-native/Libraries/ActionSheetIOS/**/*.js',
   'react-native/Libraries/TurboModule/RCTExport.js',
   'react-native/Libraries/Types/RootTagTypes.js',
@@ -115,7 +115,7 @@ function getBuildPath(file /*: string */) /*: string */ {
     packageDir,
     file
       .replace(packageDir, TYPES_DIR)
-      .replace(/\.flow\.js$/, '.js')
+      .replace(/\.js\.flow$/, '.js')
       .replace(/\.js$/, '.d.ts'),
   );
 }
@@ -126,15 +126,15 @@ function ignoreShadowedFiles(files /*: Array<string> */) /*: Array<string> */ {
 
   // Find all flow definition files that shadow other files
   for (const file of files) {
-    if (/\.flow\.js$/.test(file)) {
+    if (/\.js\.flow$/.test(file)) {
       shadowedPrefixes[file.substring(0, file.length - 8)] = true;
     }
   }
 
   // Filter out all files shadowed by flow definition files
   for (const file of files) {
     const prefix = file.split('.')[0];
-    if (/\.flow\.js$/.test(file) || !shadowedPrefixes[prefix]) {
+    if (/\.js\.flow$/.test(file) || !shadowedPrefixes[prefix]) {
       result.push(file);
     }
   }