Skip to content

Commit 9350d6f

Browse files
EvanBaconfacebook-github-bot
authored andcommitted
React: Update conditional compilation for RCTKeyCommands to include only simulator and Mac Catalyst (#49154)
Summary: Support distributing Expo Dev Clients to TestFlight. Expo Dev Clients are like custom versions of Expo Go that you can use to connect to a dev server or test remote updates with. Currently they can only be distributed through AdHoc provisioning because Apple rejects the use of private symbols. The symbols in question are used for simulator builds to support reloading when the "R" key is pressed (amongst other features). This is not imperative since there are a number of systems for reloading the app such as pressing R in the CLI window, but it's also not relevant to a physical phone where there is no keyboard. ## Changelog: [IOS] [FIXED] - Remove private symbols for non-simulator and non-catalyst builds. <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: #49154 Test Plan: - I built an deployed an app with this patch enabled to TestFlight to ensure the submission wouldn't fail. This can be reproduced locally with: - `npx create-expo` - Add the patch (ensure it's set with a `prepare` script). - Following `eas.json`: ```json { "cli": { "version": ">= 14.7.0", "appVersionSource": "remote" }, "build": { "development": { "developmentClient": true, "resourceClass": "large", "autoIncrement": true }, "production": { "autoIncrement": true } }, "submit": { "production": {}, "development": {} } } ``` - Then building and deploying to TestFlight: `npx eas-cli@latest build -p ios -s --profile development` Reviewed By: huntie Differential Revision: D69106388 Pulled By: cipolleschi fbshipit-source-id: 773a897ff5061929367b72188f06a08213c7dd46
1 parent 55b3839 commit 9350d6f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/react-native/React/Base/RCTKeyCommands.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
#import "RCTDefines.h"
1515
#import "RCTUtils.h"
1616

17-
#if RCT_DEV
17+
#if RCT_DEV && (TARGET_OS_SIMULATOR || TARGET_OS_MACCATALYST)
1818

1919
@interface UIEvent (UIPhysicalKeyboardEvent)
2020

0 commit comments

Comments
 (0)