Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No validation that an @refetchable queryName is not the name of a fragment #4894

Open
rbalicki2 opened this issue Jan 24, 2025 · 0 comments
Open

Comments

@rbalicki2
Copy link
Contributor

rbalicki2 commented Jan 24, 2025

  • If a @refetchable fragment has a queryName which is the name of an existing fragment (say MyFragment), then __generated__/MyFragment.graphql will be the ReaderFragment, and not the ConcreteRequest.
  • If a persisted queries json file is created (and presumably if the query is persisted to the backend?), then the persisted "query" is actually just the fragments.
  • Relay should enforce that queryName is globally unique. (Presumably there can be collisions with other query names, too, didn't check)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant