Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent behaviour of max_len and length in Interaction #137

Open
mbaroni opened this issue Nov 5, 2020 · 0 comments
Open

Inconsistent behaviour of max_len and length in Interaction #137

mbaroni opened this issue Nov 5, 2020 · 0 comments
Assignees
@mbaroni @robertodessi @eugene-kharitonov
Labels
enhancement New feature or request

Comments

@mbaroni
Copy link
Contributor

mbaroni commented Nov 5, 2020

max_len sets max length without considering the extra mandatory EOS at the end, however the length field in the Interaction object stores average length considering EOS. Consequently, if messages are always of maximum length, we have a somewhat surprising behaviour in which given max_len==N, the average length in the length field might be N+1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbaroni mbaroni

@robertodessi robertodessi

@eugene-kharitonov eugene-kharitonov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mbaroni @robertodessi @eugene-kharitonov