Skip to content

Create toggle switch #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
happyshows opened this issue Feb 19, 2019 · 4 comments
Closed

Create toggle switch #136

happyshows opened this issue Feb 19, 2019 · 4 comments

Comments

@happyshows
Copy link

Hi,

Is there plan to add something like this?
twbs/bootstrap#15783

@tcbegley
Copy link
Collaborator

Yes, we would like to add those. They actually only fairly recently got added to reactstrap, the underlying ReactJS library that we use to make dash-bootstrap-components. This means that adding the switch will require upgrading the version of reactstrap that we use and as a result is a bigger job than just adding a new component. But it would definitely good for us to support the toggle and all the other custom inputs.

@tcbegley
Copy link
Collaborator

tcbegley commented Feb 19, 2019

I think reactstrap 7 uses createPortal for rendering Popover and maybe some other components we currently have, which is incompatible with the version of React that dash-renderer uses. If I'm not mistaken about that, then updating the version of reactstrap we're using will have to wait until Dash 1.0 is released, which might take a little while, otherwise we'll break existing components.

@happyshows
Copy link
Author

ok thanks.

@tcbegley tcbegley mentioned this issue Mar 4, 2019
7 tasks
@tcbegley
Copy link
Collaborator

tcbegley commented Mar 6, 2019

This is now being tracked in #142

@tcbegley tcbegley closed this as completed Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants