Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync will not delete folder containing git repository #26

Open
tcbegley opened this issue Jun 7, 2018 · 2 comments
Open

Sync will not delete folder containing git repository #26

tcbegley opened this issue Jun 7, 2018 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@tcbegley
Copy link
Contributor

tcbegley commented Jun 7, 2018

I was using sml-sync on a project with multiple Git repositories. I deleted a folder containing one such repository and synced up. Now however I see this

image

And it persists no matter how many times I press [u]. I don't know what the best way to handle this is, I appreciate that deleting a Git repository is potentially dangerous, but perhaps there would be a better way of communicating to the user why the remote folder isn't getting deleted?

@janfreyberg
Copy link
Contributor

@liamcoatman just pointed out that this is true for all files that are set as "ignored", e.g. __pycache__.

I think this should be the behaviour (in case there's a .git repo as in @tcbegley's case, or if there are notebooks or data files in a directory), but it should be communicated why the folders didn't get deleted (if that's possible).

@janfreyberg janfreyberg added the bug Something isn't working label Jun 14, 2018
@janfreyberg
Copy link
Contributor

One good idea by @tcbegley is to completely ignore directories that are empty (or perceived to be empty due to ignored files), similar to how git works

@srstevenson srstevenson added the good first issue Good for newcomers label Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Development

No branches or pull requests

3 participants