Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate clients from namedtuples/attr datastructures to dataclassess #199

Open
imrehg opened this issue Feb 23, 2022 · 2 comments
Open

Migrate clients from namedtuples/attr datastructures to dataclassess #199

imrehg opened this issue Feb 23, 2022 · 2 comments

Comments

@imrehg
Copy link
Member

imrehg commented Feb 23, 2022

As the API client is doing now, use the more up to date and Python built in dataclassess where needed.

Originally posted by @acroz in #197 (comment)
@imrehg imrehg mentioned this issue May 13, 2022
Merged
@shehab-as
Copy link

If this has not been picked up I can give it a go? Interested to familiarize myself with the codebase.

@imrehg
Copy link
Member Author

imrehg commented Oct 14, 2022

@ShehabMMohamed I think that would be cool. It would be nice to finish up #197 and based on that do all the changes (and also adding the coverage for Apps)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imrehg @shehab-as