From 479face743a68ee9651bdf9ffea554727dd68551 Mon Sep 17 00:00:00 2001 From: jbleyel Date: Thu, 18 Jan 2024 12:23:16 +0100 Subject: [PATCH] eListboxPythonServiceContent: fix sonar warning --- lib/service/elistboxservicecontent.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/service/elistboxservicecontent.cpp b/lib/service/elistboxservicecontent.cpp index e76be9908e..64334e6dd6 100644 --- a/lib/service/elistboxservicecontent.cpp +++ b/lib/service/elistboxservicecontent.cpp @@ -567,13 +567,14 @@ bool eListboxPythonServiceContent::getIsMarked(int selected) void eListboxPythonServiceContent::setBuildArgs(int selected) { eServiceReference &ref = *m_service_cursor; + bool isSelected = selected > 0; bool isFolder = ref.flags & eServiceReference::isDirectory; bool isMarker = ref.flags & eServiceReference::isMarker; bool isPlayable = !(isFolder || isMarker); bool isRecorded = m_record_indicator_mode && isPlayable && checkServiceIsRecorded(ref,pNavigation::RecordType(pNavigation::isRealRecording|pNavigation::isUnknownRecording)); bool isStreamed = m_record_indicator_mode && isPlayable && checkServiceIsRecorded(ref,pNavigation::isStreaming); bool isPseudoRecorded = m_record_indicator_mode && isPlayable && checkServiceIsRecorded(ref,pNavigation::isPseudoRecording); - bool marked = ((m_current_marked && selected) || (cursorValid() && isMarked(*m_service_cursor))); + bool marked = ((m_current_marked && isSelected) || (cursorValid() && isMarked(*m_service_cursor))); // status bitmask // 1 selected @@ -585,7 +586,7 @@ void eListboxPythonServiceContent::setBuildArgs(int selected) // 64 isPseudoRecorded // 128 isFolder - int status = (selected << 0) + (marked << 1) + (isMarker << 2) + (isPlayable << 3) + (isRecorded << 4) + (isStreamed << 5) + (isPseudoRecorded << 6) + (isFolder << 7); + int status = (isSelected << 0) + (marked << 1) + (isMarker << 2) + (isPlayable << 3) + (isRecorded << 4) + (isStreamed << 5) + (isPseudoRecorded << 6) + (isFolder << 7); m_pArgs = PyTuple_New(2); PyTuple_SET_ITEM(m_pArgs, 0, NEW_eServiceReference(ref));