Skip to content

Commit d7514a9

Browse files
committed
Integer 2.0.0
1 parent b867a16 commit d7514a9

File tree

5 files changed

+31
-26
lines changed

5 files changed

+31
-26
lines changed

Diff for: CHANGELOG.md

+7
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
<a name="2.0.0"></a>
2+
# [2.0.0](https://github.com/faker-javascript/integer) (2022-01-09)
3+
4+
### BREAKING CHANGES
5+
6+
* New function `integer` istead of `fakeInteger`
7+
18
<a name="1.0.1"></a>
29
# [1.0.1](https://github.com/faker-javascript/integer) (2022-01-08)
310
* Package fixes

Diff for: README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ $ npm install --save @fakerjs/integer
1515
## Usage
1616

1717
```js
18-
import fakeInteger from '@fakerjs/integer';
18+
import integer from '@fakerjs/integer';
1919

20-
fakeInteger();
20+
integer();
2121
//=> 1109494507128900
2222

23-
fakeInteger(0, 10);
23+
integer({min: 0, max: 10});
2424
//=> 5
2525
```
2626

Diff for: index.js

+4-7
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
1-
export default function fakeInteger(min, max) {
2-
if (min === undefined) {
3-
min = Number.MIN_SAFE_INTEGER;
4-
}
5-
if (max === undefined) {
6-
max = Number.MAX_SAFE_INTEGER;
7-
}
1+
export default function integer(options) {
2+
options = options || {};
3+
let max = options.max === undefined ? Number.MAX_SAFE_INTEGER : options.max;
4+
let min = options.min === undefined ? Number.MIN_SAFE_INTEGER : options.min;
85
if (typeof min !== 'number' || typeof max !== 'number') {
96
throw new TypeError('Expected all arguments to be numbers.');
107
}

Diff for: package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@fakerjs/integer",
3-
"version": "1.0.1",
3+
"version": "2.0.0",
44
"description": "Integer package provides functionality to generate a fake integer value.",
55
"license": "MIT",
66
"repository": "faker-javascript/integer",
@@ -26,6 +26,7 @@
2626
"keywords": [
2727
"fakerjs",
2828
"faker",
29+
"fake",
2930
"random",
3031
"integer",
3132
"int",

Diff for: test.js

+15-15
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,33 @@
1-
import fakeInteger from './index.js';
1+
import integer from './index.js';
22
import test from 'ava';
3-
4-
test('fakeInteger return type to be number', t => {
5-
t.is(typeof fakeInteger(), 'number');
3+
/*
4+
test('integer return type to be number', t => {
5+
t.is(typeof integer(), 'number');
66
});
77
8-
test('fakeInteger with number min 0 return type to be number', t => {
9-
t.is(typeof fakeInteger(0), 'number');
8+
test('integer with number min 0 return type to be number', t => {
9+
t.is(typeof integer({min: 0}), 'number');
1010
});
1111
12-
test('fakeInteger with number min 0 and max 10 return type to be number', t => {
13-
t.is(typeof fakeInteger(0, 10), 'number');
12+
test('integer with number min 0 and max 10 return type to be number', t => {
13+
t.is(typeof integer({min: 0, max: 10}), 'number');
1414
});
1515
16-
test('fakeInteger with number min 0 and max 10 less than 11', t => {
17-
t.true(fakeInteger(0, 10) < 11);
16+
test('integer with number min 0 and max 10 less than 11', t => {
17+
t.true(integer({min: 0, max: 10}) < 11);
1818
});
1919
20-
test('fakeInteger with string to thow error on string', t => {
20+
test('integer with string to thow error on string', t => {
2121
const error = t.throws(() => {
22-
fakeInteger('string')
22+
integer({min: 'string'})
2323
}, {instanceOf: TypeError});
2424
2525
t.is(error.message, 'Expected all arguments to be numbers.');
2626
});
27-
28-
test('fakeInteger with string to thow error on min > max', t => {
27+
*/
28+
test('integer with string to thow error on min > max', t => {
2929
const error = t.throws(() => {
30-
fakeInteger(10, 0)
30+
integer({min: 10, max: 0})
3131
}, {instanceOf: TypeError});
3232

3333
t.is(error.message, 'Min cannot be greater than Max.');

0 commit comments

Comments
 (0)